Print Z_bneg as logical negation in Rust and Zig - #2422
Draft
JasonGross wants to merge 1 commit into
Draft
Conversation
Emit zero tests instead of integer bitwise complements, track the one-bit natural result for cast insertion, and add focused emitter regressions. Regenerate the affected Rust and Zig outputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Z_bnegas a zero comparison cast to the generated one-bit typeZ_bnegwith@intFromBoolThis fixes the latent emitter mismatch described in Scrutineer finding #2525. Each generated artifact changes one expression line.
Testing
opam exec --switch=rocq-9.1 -- make -j4 SKIP_BEDROCK2=1 src/Stringification/Rust.vo src/Stringification/Zig.vocargo test --offlinezig buildzig build testgit diff --checkThe Cargo crate currently has no unit/doc tests, so Cargo validates full compilation; the exact emitted syntax is covered by the Rocq regression examples.