Correct generated msat postconditions - #2420
Draft
JasonGross wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
msatas the saturated(n+1)-limb representation whose two’s-complement value is exactly the modulusRationale
msatreturns the modulus itself. Its old contract reused the ordinary field-elementvalidpredicate, producing contradictory postconditions:twos_complement_eval out1 = mand0 ≤ eval out1 < m. The corrected contract preserves the exact-value and limb-bound guarantees while removing the false< mclaim. This fixes Scrutineer finding #2524.All generated changes are comment-only: each affected file only loses the false postcondition line.
Testing
git diff --checkGo and Java compilers were unavailable locally; their generated diffs were verified to be comment-only.