Feature/mintlayer app by OBorce · Pull Request #1 · mintlayer/mintlayer-ledger-app

OBorce · 2025-09-30T08:14:16Z

No description provided.

Update to latest SDK

use dedicated sections for each device

Moving to new manifest format

Code cleanup.

…s return type

Update app : features, UI, tests, CI.

ImplOfAnImpl

I didn't have enough time to look through all the code, I'll continue after returning from my vacation.

ImplOfAnImpl · 2025-12-19T16:22:19Z

+# By default, heap size is enforced to 8192 bytes.
+# Authorized values are [2048, 4096, 8192, 16384, 24576]
+# Uncomment the following lines to set the heap size to 4096 bytes for instance
+[env]
+HEAP_SIZE = "16384"


Plz remove the original comment and write our own, explaining why we need this particular heap size

ImplOfAnImpl · 2025-12-19T16:45:27Z

@@ -0,0 +1,44 @@
+name: Build and run functional tests using ragger through reusable workflow


Rename the file to build_and_run_functional_tests.yml?

I didn't rename it as it comes from their boilerplate app conventions

ImplOfAnImpl · 2025-12-19T18:06:01Z

+[profile.release]
+opt-level = 'z'
+lto = true


Another thing worth adding here is codegen-units = 1
E.g. I tried building for apex_p. Before:

# llvm-size /app/target/apex_p/release/mintlayer-app text data bss dec hex filename 145080 1024 19576 165680 28730 /app/target/apex_p/release/mintlayer-app

and with codegen-units = 1:

# llvm-size /app/target/apex_p/release/mintlayer-app text data bss dec hex filename 136224 1024 19576 156824 26498 /app/target/apex_p/release/mintlayer-app

I.e. the app will occupy 136224+1024 bytes of flash instead of 145080+1024.

P.S. the BSS section is the amount of RAM that the app's static data will occupy (it will be filled with zeroes at startup). I wonder whether this value is high and, if yes, whether we should look for ways to reduce it. IMO it'd make sense to at least look at other app's binaries (e.g. Ethereum and Bitcoin) and check their BSS sections (will need to build the apps from source for this).
One possible way of trying to reduce it would going through all dependencies and turning off all unneeded default features.

ImplOfAnImpl

TBF I'm tired from your approach to PRs. From now on I want:

A clear indication of when a PR is ready for review. Normally, after changes have been requested, the PR should be changed to draft and when it comes back to "ready for review", then it's the indication that it is ready. If the PR never went to the draft state, then there should be some other indication, e.g. a comment "ready for review" or something. I will no longer look at PRs without clear indication that they're ready.
The code in a non-draft PR should be of production quality. No forgotten pieces of the original boilerplate app, no unused entities, outdated comments. Also, the usual general best practices should have already been applied - code duplication reduced to minimum, named constants instead of magic numbers etc.
(Btw, I'm not telling that the code should not have issues at all. But there is a huge difference between missing an issue and not bothering to even check).
To achieve #2 you have to review your own PRs. At least scroll through the diff looking for obvious issues/dirty code. E.g. I do this with my own PRs.
If you don't bother reviewing your own code, why should I. Doing code review is not pleasant and having to proof-read someones dirty code over and over again sucks all the fun from developer's life.
All review comments should be addressed, which means: applying the comment, initialing its discussion, either on GitHub or Slack, dropping it with a counter-comment, adding TODO to investigate it later, etc. Basically anything will do, except for silently ignoring it.
Again, accidents can happen, especialy in a large PR, but if they happen too often, then maybe the author of the PR doesn't care enough. And if he doesn't, then why should the reviewer care to write them, right?

ImplOfAnImpl · 2026-01-19T09:56:16Z

+        // version
+        tx_hasher
+            .update(&[version])
+            .map_err(|_| StatusWord::TxHashFail)?;


This is conceptually wrong - if we ever have Transaction::V2, it may have a completely different structure. So, instead of blindly encoding the version value, we should check if it's 1 and fail if it's not.
Also, the tx version should probably be an enum inside messages, e.g. TransactionVersion.

Made the tx version into an enum in the requests

ImplOfAnImpl · 2026-01-22T11:35:01Z

+}
+
+struct Context {
+    pub data: DataContext,


data_context

Though I'm not sure why the word "data" is here, probably the struct should be just Context and the field context.

Not sure about this one, as the outer struct is already named Context

Not sure about this one, as the outer struct is already named Context

The name of the outer struct has nothing to do with this. The type of data is DataContext, which means "context related to data", so it's a "context", i.e. names like context or data_context would make sense, but data doesn't. But if the type was named ContextData, which would mean "data related to context", then data or context_data would make sense.
Plz decide whether your type is "data context" or "context data" and name both it and the field accordingly.

…rkflows. Run cargo-fmt. Update ledger_device_sdk version.

Update mintlayer-core-primitives repo revision. Enable disabled CI workflows.

yhql and others added 30 commits June 20, 2023 11:21

fmt

edac388

Merge pull request #27 from LedgerHQ/update

7431fcf

Update to latest SDK

use dedicated sections for each device

f8b14e2

Merge pull request #28 from yogh333/feat/update_manifest

c1e2849

use dedicated sections for each device

[clean] Moving to new manifest format

43e50eb

Merge pull request #32 from LedgerHQ/update/manifest

f3d9f26

Moving to new manifest format

Add new main menu based on MultiPageMenu gadget.

3444069

Use MultiFieldReview gadget for tx review.

14aa875

Update authors, version and crate name in Cargo.toml

6da298a

Update .gitignore

9cfd8a2

Update app instruction handling and UI.

5d2ca17

Add Ragger tests and remove obsolete functional tests.

e423064

Add transaction signing APDU handling and display.

00d537f

Stack usage optim : use slices, not arrays in Tx struct.

0cab934

Code cleanup.

Add test snapshots for LNX / LNSP

11b9590

Remove unnecessary fields from config.toml

6e48413

Remove local version of nanos_ui in Cargo.toml

b134372

Format

b57d5bd

Use dependencies from the new SDK workspace.

a132cd4

Code cleanup.

Introduce new App Status Words enum and use it instead of io::Reply a…

337f1b9

…s return type

Update CI

3c16549

Merge pull request #31 from LedgerHQ/update-app

0aafd40

Update app : features, UI, tests, CI.

Update dependencies to latest SDK versions for update .elf metadatas

955db01

Update CI with reusable workflows

7821659

Update app manifest to add pytest directory field.

b98ef03

Ignore word "crate" in misspelling checks.

83f1e4e

Rename python tests checks workflow for clarity.

1d35ecc

Add "name" field in Cargo.toml [package.metadata.ledger] category

69ef4c2

Fix static analysis

6972549

Update pending review function

23ec722

OBorce added 2 commits December 18, 2025 04:51

flatten tx inputs for better memory efficiency

2a03f21

Use new TxInfoWithAdditionalInfo

5faeaaf

OBorce force-pushed the feature/mintlayer-app branch from 98949a4 to 5faeaaf Compare December 19, 2025 02:36

fix tests

b87b78a

ImplOfAnImpl reviewed Dec 19, 2025

View reviewed changes

OBorce added 2 commits December 24, 2025 12:36

fix comments

ad084ac

bump deps and toolchain

9ca7570

OBorce force-pushed the feature/mintlayer-app branch from bf565b1 to 9ca7570 Compare January 15, 2026 07:30

ImplOfAnImpl requested changes Jan 22, 2026

View reviewed changes

OBorce added 3 commits February 6, 2026 16:53

Move StatusWord to messages crate

dbc4134

restrict message display to printable ASCII characters only

9c7c50e

Add Ping command

985e76c

ImplOfAnImpl mentioned this pull request Apr 14, 2026

Update mintlayer-core-primitives repo revision. Enable disabled CI workflows. #3

Merged

ImplOfAnImpl and others added 2 commits April 15, 2026 13:13

Update mintlayer-core-primitives repo revision. Enable disabled CI wo…

ffe0d62

…rkflows. Run cargo-fmt. Update ledger_device_sdk version.

Merge pull request #3 from mintlayer/update_ml_primitives_rev

a544449

Update mintlayer-core-primitives repo revision. Enable disabled CI workflows.

OBorce marked this pull request as draft April 20, 2026 10:13

OBorce added 5 commits April 27, 2026 16:44

Refactor response types

928777c

Reafactor utils and imports

4391b8b

Extract Tx summary collector

26fb5f2

add minimal changes for input command review

4d91763

fix tests

39666c7

OBorce force-pushed the feature/mintlayer-app branch 6 times, most recently from 6b7b7d6 to b1a037f Compare May 27, 2026 07:39

fix nanox tests

54deb76

OBorce force-pushed the feature/mintlayer-app branch from b1a037f to 54deb76 Compare May 27, 2026 07:48

OBorce marked this pull request as ready for review May 27, 2026 08:04

		@@ -0,0 +1,44 @@
		name: Build and run functional tests using ragger through reusable workflow

Conversation

OBorce commented Sep 30, 2025

Uh oh!

ImplOfAnImpl left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ImplOfAnImpl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants