Skip to content

add disable ssl flag for bucket replication #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harshavardhana merged 6 commits into from
Oct 1, 2025
Merged

add disable ssl flag for bucket replication #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
29bf626
add disable tls flag
dormanze Aug 5, 2025
9d641ab
Apply suggestion from @harshavardhana
harshavardhana Aug 9, 2025
43bc5b0
Apply suggestion from @harshavardhana
harshavardhana Aug 9, 2025
9493d5a
Update bucket-targets.go
dormanze Aug 11, 2025
2a9a392
update gen
dormanze Aug 11, 2025
2f1fb05
update api support InsecureTLS flag
dormanze Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions bucket-targets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ type BucketTarget struct {
Edge bool `json:"edge"` // target is recipient of edge traffic
EdgeSyncBeforeExpiry bool `json:"edgeSyncBeforeExpiry"` // must replicate to edge before expiry
OfflineCount int64 `json:"offlineCount"`
InsecureTLS bool `json:"insecureTLS"`
}

// Credentials holds access and secret keys.
Expand Down Expand Up @@ -126,6 +127,7 @@ func (t *BucketTarget) Clone() BucketTarget {
Edge: t.Edge,
EdgeSyncBeforeExpiry: t.EdgeSyncBeforeExpiry,
OfflineCount: t.OfflineCount,
InsecureTLS: t.InsecureTLS,
}
}

Expand Down
35 changes: 30 additions & 5 deletions bucket-targets_gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions remote-target-commands.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,8 @@ const (
EdgeUpdateType
// EdgeExpiryUpdateType sets bucket target to sync before expiry
EdgeExpiryUpdateType
// InsecureTLSUpdateType update tls setting
InsecureTLSUpdateType
)

// GetTargetUpdateOps returns a slice of update operations being
Expand All @@ -184,6 +186,9 @@ func GetTargetUpdateOps(values url.Values) []TargetUpdateType {
if values.Get("proxy") == "true" {
ops = append(ops, ProxyUpdateType)
}
if values.Get("tls") == "true" {
ops = append(ops, InsecureTLSUpdateType)
}
if values.Get("healthcheck") == "true" {
ops = append(ops, HealthCheckDurationUpdateType)
}
Expand Down Expand Up @@ -227,6 +232,8 @@ func (adm *AdminClient) UpdateRemoteTarget(ctx context.Context, target *BucketTa
queryValues.Set("sync", "true")
case ProxyUpdateType:
queryValues.Set("proxy", "true")
case InsecureTLSUpdateType:
queryValues.Set("tls", "true")
case BandwidthLimitUpdateType:
queryValues.Set("bandwidth", "true")
case HealthCheckDurationUpdateType:
Expand Down
Loading