Support checks for required_status_checks#151
Open
Cyb3r-Jak3 wants to merge 2 commits intomineiros-io:mainfrom
Open
Support checks for required_status_checks#151Cyb3r-Jak3 wants to merge 2 commits intomineiros-io:mainfrom
checks for required_status_checks#151Cyb3r-Jak3 wants to merge 2 commits intomineiros-io:mainfrom
Conversation
|
Thanks @Cyb3r-Jak3 for your effort. The changes in this PR may already be addressed by #148. Hopefully, we can merge one of these PRs soon. |
Author
|
@switchdk I looked at #148, and it seems to be a breaking change, even though that GitHub terraform provider supports both https://github.com/integrations/terraform-provider-github/blob/main/github/resource_github_branch_protection_v3.go#L42-#L75 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for
checksas a part ofrequired_status_checks. GitHub integration docsResolves #147