p2p: compare peers ports to allow running multiple nodes from single IP by ardocrat · Pull Request #3864 · mimblewimble/grin

ardocrat · 2026-06-16T09:45:12Z

Allow to launch several nodes under single non-global IP.
Do not store private addresses at db
Set default chain port for peers on parsing error from config
Ignore port for deny/allow peers when :0 port specified

Open problem: if you run node behind a proxy, it will use local ip address for peers as native socket API is spreading first available address, we just use port from config at handshake.

…network

This reverts commit c3b01e8.

This reverts commit b89c21d.

# Conflicts: # p2p/src/peers.rs

# Conflicts: # config/src/config.rs

…in_type` automatically

ardocrat added 5 commits June 16, 2026 12:28

p2p: compare peers ports to allow running multiple nodes from single IP

9cca7a6

p2p: allow multiple peers with same IP address if belongs to private …

07d9051

…network

p2p: fix peers hash tests, move peers ports to constants

a6a6430

p2p: check shared ip only for v4

108e52d

p2p: generate random ports

c3b01e8

ardocrat requested a review from wiesche89 June 16, 2026 16:28

wiesche89 reviewed Jun 16, 2026

View reviewed changes

Comment thread p2p/src/types.rs Outdated

wiesche89 reviewed Jun 16, 2026

View reviewed changes

Comment thread config/src/config.rs Outdated

ardocrat added 2 commits June 16, 2026 20:57

Revert "p2p: generate random ports"

7c1a0f6

This reverts commit c3b01e8.

p2p: do not store private IPs peers

1ed86de

wiesche89 reviewed Jun 16, 2026

View reviewed changes

Comment thread p2p/src/store.rs Outdated

Comment thread p2p/src/peers.rs Outdated

Comment thread p2p/src/peers.rs Outdated

ardocrat added 2 commits June 17, 2026 13:27

p2p: do not update state for deleted private peer

da70d2f

p2p: commit peer deletion

c377be2

wiesche89 reviewed Jun 26, 2026

View reviewed changes

Comment thread p2p/src/peers.rs

Comment thread p2p/src/peers.rs

Comment thread p2p/src/types.rs Outdated

ardocrat added 3 commits June 26, 2026 12:38

peers: save peer on ban if not exists

6d8211d

p2p: check denied provided port on handshake for inbound peers

b89c21d

p2p: improve handshake test, add allow/deny peers tests

855e2a1

wiesche89 reviewed Jun 26, 2026

View reviewed changes

Comment thread p2p/src/handshake.rs Outdated

Revert "p2p: check denied provided port on handshake for inbound peers"

4ae63d1

This reverts commit b89c21d.

wiesche89 reviewed Jun 26, 2026

View reviewed changes

Comment thread p2p/src/types.rs Outdated

p2p: comment port ignore only for public IPs

a8a9ecf

wiesche89 reviewed Jun 29, 2026

View reviewed changes

Comment thread p2p/src/types.rs

Comment thread p2p/src/types.rs Outdated

Comment thread p2p/src/types.rs Outdated

Comment thread p2p/src/peers.rs

Comment thread config/src/comments.rs Outdated

ardocrat added 4 commits June 30, 2026 14:56

ip: try convert ipv6 to ipv4

8d19b52

Merge branch 'staging' into peers_compare_ports

f632b96

# Conflicts: # p2p/src/peers.rs

p2p: check allowed/denied peers ignoring empty port

c5702ad

p2p: set default chain port on peers parse error from config

bce3c0d

wiesche89 reviewed Jun 30, 2026

View reviewed changes

Comment thread p2p/src/peer.rs Outdated

Comment thread p2p/src/types.rs Outdated

Comment thread p2p/src/types.rs Outdated

ardocrat added 3 commits July 1, 2026 12:50

p2p: compare non-private peers only by IP on deny/allow check

d70da02

fix: initialize global chain type before config parse

2b96abc

Merge branch 'staging' into peers_compare_ports

dcc6583

# Conflicts: # config/src/config.rs

wiesche89 added 5 commits July 3, 2026 17:33

validate chain type before config load

5662377

fix private peer ban keys

de69bf4

fix portless private peer filters

5540d44

reuse peer filter matching

25fc059

fix peer address edge cases

ab8963f

wiesche89 approved these changes Jul 3, 2026

View reviewed changes

config: reuse file path for server

24e5f66

ardocrat commented Jul 3, 2026

View reviewed changes

Comment thread src/bin/grin.rs

ardocrat commented Jul 3, 2026

View reviewed changes

Comment thread src/bin/grin.rs Outdated

ardocrat and others added 4 commits July 3, 2026 23:32

config: do not set local chain_type as we set it while getting `cha…

8bfd69e

…in_type` automatically

p2p: check denied peers when connecting to seeds

8abd45d

fix peer filter edge cases

b3bb534

normalize mapped peer addresses

b4b6bd3