Integrated Tor arti Client by ardocrat · Pull Request #750 · mimblewimble/grin-wallet

ardocrat · 2026-05-22T22:30:20Z

Integrated Arti client for listener (https://gitlab.torproject.org/tpo/core/arti/)
Bridges support
Added bridge_bin_path and use_integrated options at config
Update tokio to last version
Use Arti client to send requests
Do not try to send if skip_send_attempt presents at config

# Conflicts: # Cargo.lock

…mpt` set at config

wiesche89 · 2026-06-20T17:14:19Z

+				path
+			};
+			let tor = if config.use_integrated.unwrap_or(true) {
+				start_tor_client(tor_dir.to_str().unwrap(), config.clone())?


The Arti sender seems to bootstrap a fresh client for each send workflow. In long-running or batch use this can add repeated delays of up to 60s. Could we reuse a bootstrapped client?

we can keep tor client as global state, currently at CLI there is no such case, there is on request per command

Agreed, for one shot CLI commands this is less visible. I was mainly thinking about Owner API, GUI or long running wallet usage, where multiple sends can happen in the same process.

# Conflicts: # Cargo.lock

… missing, add logging

ardocrat added 3 commits May 23, 2026 01:27

tor: integrated client for listener, update tokio to last version

ad5c745

tor: send transaction with integrated client

0f88f7a

build: code format

0195c16

wiesche89 mentioned this pull request Jun 2, 2026

Agenda: Development, 02 june 2026 mimblewimble/grin-pm#458

Open

This was referenced Jun 3, 2026

Alot of TOR zombie processes #510

Closed

tor not found #574

Closed

support Socks5Proxy config #585

Closed

wiesche89 self-requested a review June 6, 2026 18:36

wiesche89 reviewed Jun 7, 2026

View reviewed changes

Comment thread impls/src/tor/arti.rs Outdated

Comment thread impls/src/tor/arti.rs Outdated

Comment thread impls/src/tor/arti.rs

Comment thread controller/src/controller.rs Outdated

ardocrat added 4 commits June 7, 2026 17:49

tor: optimize bootstrap percent check

8d5ac7b

tor: handle config build error

379b094

tor: do not show slatepack address if tor not launched

efd73ce

tor: handle keystore errors

bef3c4c

wiesche89 reviewed Jun 8, 2026

View reviewed changes

Comment thread controller/src/controller.rs Outdated

tor: keep service launched

aec5fa1

ardocrat mentioned this pull request Jun 8, 2026

grin-wallet listen generates address without Mainnet or Testnet prefix OR shows pubkey #740

Closed

wiesche89 reviewed Jun 9, 2026

View reviewed changes

Comment thread impls/src/tor/arti.rs Outdated

Comment thread impls/src/tor/arti.rs Outdated

Comment thread impls/src/tor/arti.rs

ardocrat added 3 commits June 9, 2026 12:24

tor: bootstrap timeout, clean cache before client launch

4316385

Merge branch 'staging' into arti

4ea8cd2

tor: post request timeout

51fe193

This was referenced Jun 9, 2026

Bump tokio from 0.2.25 to 1.18.5 #671

Closed

Update tokio to v1 and reqwest to v0.11 #686

Closed

wiesche89 reviewed Jun 9, 2026

View reviewed changes

Comment thread impls/src/tor/arti.rs Outdated

Comment thread impls/src/tor/arti.rs

ardocrat added 4 commits June 9, 2026 18:32

fix: post timeout

f35345f

Merge branch 'staging' into arti

8d188df

# Conflicts: # Cargo.lock

build: update deps after merge

297e533

tor: store arti runtime

903fb38

ardocrat mentioned this pull request Jun 9, 2026

Need option for Don't start local tor sender #669

Closed

ardocrat added 2 commits June 9, 2026 20:13

tor: do not send over tor if manual arg presents or `skip_send_atte…

aeddb02

…mpt` set at config

fix: arg name

d9c72dd

wiesche89 reviewed Jun 9, 2026

View reviewed changes

Comment thread impls/src/tor/arti.rs Outdated

Comment thread impls/src/tor/arti.rs Outdated

Comment thread impls/src/tor/arti.rs Outdated

Comment thread impls/src/tor/arti.rs Outdated

Comment thread impls/src/tor/arti.rs Outdated

Comment thread impls/src/tor/arti.rs Outdated

ardocrat added 9 commits June 9, 2026 21:54

tor: handle arti runtime creation error

7bb641b

tor: handle connection error

4871009

tor: handle bootstrap error

8982c91

tor: handle start service name error

ca6c9ec

tor: handle service config creation error

e266085

tor: service proxy errors

77f3e22

tor: handle service key creation emptiness

c2522b2

build: format code

f552f54

build: update arti to 0.43, hyper to 0.10.1

09fea00

ardocrat mentioned this pull request Jun 17, 2026

Tokio + Reqwest upgrade #734

Closed

wiesche89 reviewed Jun 20, 2026

View reviewed changes

Comment thread impls/src/adapters/tor.rs Outdated

Comment thread impls/src/tor/arti.rs Outdated

Comment thread controller/src/controller.rs

wiesche89 reviewed Jun 20, 2026

View reviewed changes

api: start foreign listener before tor connection

ee4dee2

wiesche89 reviewed Jun 20, 2026

View reviewed changes

Comment thread controller/src/controller.rs

ardocrat added 2 commits June 20, 2026 22:20

tor: handle json parse errors

b614831

tor: prevent to create several client runtimes, ability to recreate

23341d3

wiesche89 reviewed Jun 20, 2026

View reviewed changes

Comment thread impls/src/tor/arti.rs

Comment thread impls/src/tor/arti.rs Outdated

Comment thread impls/src/tor/arti.rs

ardocrat added 4 commits June 21, 2026 13:01

tor: return bootstrap error

68f46de

tor: handle host parse error

192e14d

tor: restart proxy on error

ea8d3c6

Merge remote-tracking branch 'grin-wallet/staging' into arti

a5dc72d

# Conflicts: # Cargo.lock

wiesche89 reviewed Jun 21, 2026

View reviewed changes

Comment thread impls/src/tor/arti.rs

wiesche89 reviewed Jun 21, 2026

View reviewed changes

Comment thread impls/src/tor/arti.rs

mimblewimble deleted a comment from ardocrat Jun 21, 2026

ardocrat added 2 commits June 21, 2026 14:56

tor: do not use integrated client when config value use_integrated is…

6182cf7

… missing, add logging

build: update lock file

79d33b9

wiesche89 merged commit 411bcff into mimblewimble:staging Jun 21, 2026
8 checks passed

ardocrat mentioned this pull request Jun 25, 2026

Increase network read timeout when sending transactions #636

Closed

wiesche89 mentioned this pull request Jun 27, 2026

Feature request: Switch to Rust-based Arti Tor client. #766

Closed

Uh oh!

Conversation

ardocrat commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wiesche89 Jun 20, 2026

Choose a reason for hiding this comment

Uh oh!

ardocrat Jun 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wiesche89 Jun 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ardocrat commented May 22, 2026 •

edited

Loading

ardocrat Jun 20, 2026 •

edited

Loading

wiesche89 Jun 20, 2026 •

edited

Loading