Skip to content

Update 0015-slatepack.md - fix for mimblewimble/grin-wallet#663#92

Open
Anynomouss wants to merge 2 commits into
masterfrom
Anynomouss-patch-RFC-documentation
Open

Update 0015-slatepack.md - fix for mimblewimble/grin-wallet#663#92
Anynomouss wants to merge 2 commits into
masterfrom
Anynomouss-patch-RFC-documentation

Conversation

@Anynomouss

Copy link
Copy Markdown

I took better and more explicit documentation on SlatepackAddress key derivation from parts of grin's cod base to make this RFC more clear to readers and in line with the current implementation in grin-wallet.

This PR addresses the following GitHub issue:
mimblewimble/grin-wallet#663

…t#663

I took better and more explicit documentation on SlatepackAddress key derivation from parts of grin's cod base to make this RFC more clear to readers and in line with the current implementation in grin-wallet.

This PR addresses the following GitHub issue:
mimblewimble/grin-wallet#663
Comment thread text/0015-slatepack.md
|m/0 | m/0/1/x |m/0/1/x |
|m/1 | m/1/1/x |m/1/1/x |

In _grin-wallet_ the x for slatepack address generation is currently fixed (`x=0`) per account. `SlatepackAddress` keys may be derived in parallel to the blinding factor derivation path such that a unique `SlatepackAddress` is derived each time a new blinding factor is derived for a transaction to satisfy the requirement for a unique `SlatepackAddress` to be used for each transaction by default.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If my understanding is correct and in derivation path (depth=2) we use: 0 for outputs and 1 for slatepack addresses, then the above example is wrong.
Should be:

Account OutputKeys SlatepackAddress key(s)
m/0 m/0/0/x m/0/1/x
m/1 m/1/0/x m/1/1/x

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct. I think I copy pasted a column and forgot to change the values 🤦‍♂️.

Fixing my sloppy edit.

|Account|OutputKeys |SlatepackAddress key(s)|
|-------|------------|----------------------|
|m/0    | m/0/0/x    |m/0/1/x               |
|m/1    | m/1/0/x    |m/1/1/x               |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants