fix: detect namespace hook calls (React.useEffect, React.useState)#118
Open
Akshay090 wants to merge 2 commits intomillionco:mainfrom
Open
fix: detect namespace hook calls (React.useEffect, React.useState)#118Akshay090 wants to merge 2 commits intomillionco:mainfrom
Akshay090 wants to merge 2 commits intomillionco:mainfrom
Conversation
Fixes millionco#117. isHookCall only checked for Identifier callee nodes, missing MemberExpression calls (React.useEffect, React.useState, etc.). Added getCalleeName helper that extracts function names from both patterns and updated all setter detection sites across helpers, state-and-effects, and performance rules. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@Akshay090 is attempting to deploy a commit to the Million Team on Vercel. A member of the Team first needs to authorize it. |
…Calls Tests cover both Identifier (useEffect) and MemberExpression (React.useEffect) patterns to validate namespace hook call detection. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #117
isHookCallonly checkedIdentifiercallee nodes, silently missingMemberExpressioncalls likeReact.useEffect(...)andReact.useState(...)getCalleeNamehelper that extracts function names from bothIdentifierandMemberExpressionnodescountSetStateCalls,noDerivedStateEffect,rerenderFunctionalSetstate,renderingHydrationNoFlicker) to use the same patternTest plan
pnpm build— passes (3 entry points built successfully)getCalleeName— 5/5 passing (Identifier, MemberExpression, null, unsupported types)isHookCall— 7/7 passing (direct calls, namespace calls, string vs Set hookName, non-CallExpression rejection)countSetStateCalls— 3/3 passing (direct setters, namespace setters, non-setter calls)npx react-doctor . --verboseon namespace imports (import * as React) —no-derived-state-effect,no-fetch-in-effect,no-cascading-set-stateall fire onReact.useEffect/React.useStatecallsnpx react-doctor . --verboseon named imports (import { useEffect }) — same rules fire, existing behavior unchanged🤖 Generated with Claude Code