Skip to content
This repository was archived by the owner on Aug 18, 2023. It is now read-only.

Support all Dynamic Type sizes throughout the app#179

Open
aopoka wants to merge 1 commit into
mikaelacaron:devfrom
aopoka:136-support-all-dynamic-type-sizes-throughout-the-app
Open

Support all Dynamic Type sizes throughout the app#179
aopoka wants to merge 1 commit into
mikaelacaron:devfrom
aopoka:136-support-all-dynamic-type-sizes-throughout-the-app

Conversation

@aopoka

@aopoka aopoka commented Oct 31, 2022

Copy link
Copy Markdown

What it Does

  • Updated the font to use the dynamic type instead of hardcoded size

How I Tested

  • Run the app in the simulator
  • Open Accessibility Inspector > Settings > change the font size to see how it is adjusting in the app

relates to #136

Update font

Update font
@aopoka aopoka requested a review from mikaelacaron as a code owner October 31, 2022 17:27
@aopoka

aopoka commented Oct 31, 2022

Copy link
Copy Markdown
Author

@mikaelacaron The only place in the code where I found the font with hardcoded size was the InteractionsView and I updated it, however, I don't see it in the TweetCard while testing

Screenshot 2022-10-31 at 18 35 13

@mikaelacaron mikaelacaron added the hacktoberfest-accepted Accepted PR for Hacktoberfest label Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

hacktoberfest-accepted Accepted PR for Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants