Stop using Rack::Logger which was removed#25
Merged
Conversation
Collaborator
|
Looks like we need a CI fix please? |
…ruby 3.4 to the matrix
Contributor
Author
|
Yeah, Thanks for quick response. I didn't notice the CI issue as it didn't got enabled in our fork by default. The issue doesn't seem to be related to the PR commit itself. It seems that FF/Gecko versions used in CI are outdated somehow. I've removed the explicitly given versions which seem to be outdated in order to use the most recent ones (I see no reason to have these specific version provided since there's no matrix for it) and it did the trick: https://github.com/Placewise/rack-server-pages/actions I've also added the most recent Ruby 3.4 to the CI matrix. |
|
I just tested |
Collaborator
Collaborator
|
I released 0.2.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24