Drop placeholder category from focus-view commands in generated containers#316832
Draft
Copilot wants to merge 2 commits into
Draft
Drop placeholder category from focus-view commands in generated containers#316832Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
…ed containers Co-authored-by: dmitrivMS <9581278+dmitrivMS@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Move outline view to activity bar and update command name
Drop placeholder category from focus-view commands in generated containers
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a view is moved out of its default container (e.g. dragging Outline from the Explorer to the Activity Bar), it lands in an auto-generated
ViewContainerwhose title is the internal placeholder"User View Container".ViewsServicewas using that title as thecategoryfor the view'sFocus on … Viewaction, so the Command Palette ended up showing entries likeUser View Container: Focus on Outline View.Changes:
viewsService.ts: when registering the focus action, passundefinedas the category if the host container is generated, so the Command Palette shows justFocus on Outline View. Behavior for views in regular containers (e.g.Explorer: Focus on Outline View) is unchanged.IViewDescriptorService: expose the previously privateisGeneratedContainerId(id)so callers can identify auto-generated containers without reaching into internals.This aligns with the existing intent already noted at the placeholder definition:
// having a placeholder title - this should not be shown anywhere.