Skip to content

Summarize aggregate scope includes scalar groupby keys #3055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anderson-joyle wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Summarize aggregate scope includes scalar groupby keys #3055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/libraries/Microsoft.PowerFx.Interpreter/Functions/LibraryTable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1429,7 +1429,10 @@ public static async ValueTask<FormulaValue> Summarize(EvalVisitor runner, EvalVi
fields.Add(field.Name, field.Value);
}

SymbolContext childContext = context.SymbolContext.WithScopeValues(thisGroupTableValue);
var scopeFields = record.Fields.Select(f => new NamedValue(f.Name, f.Value)).ToList();
scopeFields.Add(new NamedValue("ThisGroup", thisGroupTableValue));
var scopeRecord = FormulaValue.NewRecordFromFields(scopeFields);
SymbolContext childContext = context.SymbolContext.WithScopeValues(scopeRecord);

foreach (LambdaFormulaValue arg in args.Where(arg => arg is LambdaFormulaValue))
{
Expand Down
25 changes: 25 additions & 0 deletions src/tests/Microsoft.PowerFx.Core.Tests.Shared/ExpressionTestCases/Summarize.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,3 +473,28 @@ Table({Fruit:"Grapes",Price:215},{Fruit:"Lemons",Price:30},{Fruit:"Bananas",Pric
{Supplier:"Contoso", Fruit:"Bananas", Price:12, Purchase:Date(2015,10,3), Tags: ["Mexico"]}),
Fruit, Average( ShowColumns( ThisGroup, Price ), Price ) As Price )
Table({Fruit:"Grapes",Price:215},{Fruit:"Lemons",Price:30},{Fruit:"Bananas",Price:12})

// === Regression: issue #2876 - groupby key referenced directly inside aggregate expression ==

// Dec2Hex over bare groupby key - was a runtime error before the fix.
>> Summarize( [{Value:1,Sixteen:1}], Sixteen, Dec2Hex( Sixteen, 3 ) As LevelOne )
Table({LevelOne:"001",Sixteen:1})

// Same aggregate written the long way via First(ThisGroup).<field> - the pre-fix workaround.
// Must produce an identical result to the bare-reference form above.
>> Summarize( [{Value:1,Sixteen:1}], Sixteen, Dec2Hex( First(ThisGroup).Sixteen, 3 ) As LevelOne )
Table({LevelOne:"001",Sixteen:1})

// Text over bare groupby key - was a REPL hang before the fix.
>> Summarize( [{Value:1,Sixteen:1}], Sixteen, Text( Sixteen ) As LevelOne )
Table({LevelOne:"1",Sixteen:1})

// Bare groupby reference must be equivalent to First(ThisGroup).<field> inside an arithmetic expression.
>> Summarize( [{Value:1,Sixteen:1},{Value:2,Sixteen:16}], Sixteen, (Sixteen * 2) As Double )
Table({Double:2,Sixteen:1},{Double:32,Sixteen:16})

// Two-key groupby: each bare key must resolve to the correct scalar inside the aggregate.
>> Summarize(
Table({A:1,B:10,V:100},{A:1,B:10,V:200},{A:2,B:20,V:300}),
A, B, (A + B) As Sum, Sum(ThisGroup, V) As Total)
Table({A:1,B:10,Sum:11,Total:300},{A:2,B:20,Sum:22,Total:300})
Loading