Sync package-lock.json version to 0.35.12#125
Merged
Conversation
mhluska
force-pushed
the
sync-lockfile-version
branch
3 times, most recently
from
3a550b5 to
cb0a505
Compare
mhluska
force-pushed
the
sync-lockfile-version
branch
from
cb0a505 to
62e5b74
Compare
mhluska
added a commit
that referenced
this pull request
Apr 24, 2026
The deviation was encoded as { correctMove: Hit, index: ['<', 1] },
which matched when TC < 1 — where Hit is already basic strategy.
At TC >= 1 (where Double is correct per I18), _suggest returned
undefined, fell back to BasicStrategyChecker, and flagged Double
as a basic strategy error.
Fix by encoding the deviation as { correctMove: Double, index: ['>=', 1] },
consistent with every other deviation (expressing the action that
differs from basic strategy and the TC threshold where it applies).
Bump version to 0.35.13.
mhluska
added a commit
that referenced
this pull request
Apr 24, 2026
The deviation was encoded as { correctMove: Hit, index: ['<', 1] },
which matched when TC < 1 — where Hit is already basic strategy.
At TC >= 1 (where Double is correct per I18), _suggest returned
undefined, fell back to BasicStrategyChecker, and flagged Double
as a basic strategy error.
Fix by encoding the deviation as { correctMove: Double, index: ['>=', 1] },
consistent with every other deviation (expressing the action that
differs from basic strategy and the TC threshold where it applies).
Bump version to 0.35.13.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lockfile version was stuck at 0.35.5 since version bumps only updated package.json.