docs(chat): document re-set-on-error semantic for pendingToolUseID field - #141
Merged
mhersson merged 1 commit intoMay 23, 2026
Conversation
- Append one sentence to the pendingToolUseID comment clarifying that the consumed id is re-stored when SendChatMessage fails, so a UI retry correctly forwards the same tool_use_id to the runner
mhersson
deleted the
ctxmax-630/follow-up-pendingtooluseid-field-doc-missing-re-se
branch
May 23, 2026 17:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pendingToolUseIDfield comment ininternal/chat/manager.gotool_use_idis re-stored whenSendChatMessagefails, so a UI retry forwards the same id to the runnertool_use_idforwarding work; the field comment was missing this re-set-on-error lifecycleTest plan
TestManager_SendUserMessage_ToolUseID_PreservedOnSendErrorcovers the exact path described — verify it passes:go test ./internal/chat/... -run TestManager_SendUserMessage_ToolUseID_PreservedOnSendErrorgo test ./internal/chat/...go build ./internal/...