fix(spotlight-strip): surface only stalled or blocked state, not unmet deps - #136
Merged
mhersson merged 1 commit intoMay 23, 2026
Conversation
…t deps
- Filter "Needs Attention" strip on state === 'stalled' || state === 'blocked'.
Dependency-blocked cards (unmet deps in todo/in_progress/review) no longer
appear in the strip — they remain visible in their normal column.
- Rename "blocked dep" labels to "blocked" in the meta line and per-card
since-label so they describe the cards now surfaced (blocked-state, not
dep-blocked).
- Expand the aria-label to include card state ("Open <id> – stalled" /
"Open <id> – blocked") so screen-reader users get the same urgency cue
the visible since-label conveys.
- Tests: invert the prior dep-blocked surface assertion, add blocked-state
and stalled-with-unmet-deps coverage, add an aria-label assertion.
mhersson
deleted the
ctxmax-606/cards-blocked-by-dep-shouldn-t-show-up-in-needs-at
branch
May 23, 2026 13:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
state === 'stalled' || state === 'blocked'. Cards blocked only by unmet dependencies (intodo/in_progress/review) no longer appear there — they remain visible in their normal column.aria-labelto include the card state, so screen-reader users get the same urgency cue the visible since-label conveys.Recreates the work from CTXMAX-606 (lost when the runner container's push hit a transient GitHub auth failure today). Bundles the a11y follow-up CTXMAX-622 since it touches the same component.
Test plan
npm run test -- SpotlightStrip --run— 7/7 passingnpm run lint— cleannpx tsc -b— clean