refactor(chat): replace IIFE-in-JSX with flat-precompute idiom in PaneContextUsage - #131
Merged
mhersson merged 1 commit intoMay 22, 2026
Conversation
…eContextUsage
- Extract cost, showCost, costTooltip as precomputed locals before return
- Replace {(() => { ... })()} with {showCost && <span ... />} conditional block
- Use ternary for costTooltip to preserve the perf guard (formatCostTooltip
not called when glyph is hidden)
- Use title={costTooltip || undefined} instead of conditional spread
mhersson
deleted the
ctxmax-601/follow-up-paneheader-cost-glyph-iife-in-jsx-breaks
branch
May 22, 2026 21:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
{(() => { ... })()}) inPaneContextUsagewith flat precomputed locals (cost,showCost,costTooltip) and a{showCost && <span />}conditional block.chat-pane-pctblock in the same functionformatCostTooltipis still not called when the cost glyph is hidden (ternary short-circuits)title={costTooltip || undefined}replaces the prior conditional-spread, letting React omit the attribute when emptyTest plan
npm testinweb/)PaneHeader.tsxestimatedCostUsd > 0estimatedCostUsdis null, undefined, or zero