Conversation
mac641
left a comment
There was a problem hiding this comment.
Perhaps, it makes sense to add another os to matrix to reduce code duplication.
- name: ubuntu-capms # this is the name of the docker-bake target
version:
- { apt_branch: v1.32, kube_version: 1.32.9 }
- { apt_branch: v1.33, kube_version: 1.33.5 }
- { apt_branch: v1.34, kube_version: 1.34.1 }
This would also allow us to remove if: ${{ matrix.os.name == 'ubuntu' }} for capms which is duplicate as well, since this' already been specified in docker-bake.hcl.
Not sure though, if there are conflicts with version: having an array assigned as opposed to having only a number assigned 🤔
ae3f8cd to
239450e
Compare
|
@mac641 good idea, but I'd vote for this to be a separate PR or issue as there is much more involved into this. |
@vknabel Fair, let's do a separate PR. |
f757c59 to
7c91e63
Compare
Description
Adds additional images for kubernetes v1.33 and v1.34