Skip to content

build(capms): v1.33 and v1.34#367

Open
vknabel wants to merge 2 commits intomasterfrom
build-capms-v1.33-and-v1.34
Open

build(capms): v1.33 and v1.34#367
vknabel wants to merge 2 commits intomasterfrom
build-capms-v1.33-and-v1.34

Conversation

@vknabel
Copy link
Copy Markdown
Contributor

@vknabel vknabel commented Oct 31, 2025

Description

Adds additional images for kubernetes v1.33 and v1.34

@vknabel vknabel requested a review from a team as a code owner October 31, 2025 09:54
Comment thread .github/workflows/release.yaml Outdated
Copy link
Copy Markdown
Contributor

@mac641 mac641 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps, it makes sense to add another os to matrix to reduce code duplication.

- name: ubuntu-capms # this is the name of the docker-bake target
  version:
  - { apt_branch: v1.32, kube_version: 1.32.9 }
  - { apt_branch: v1.33, kube_version: 1.33.5 }
  - { apt_branch: v1.34, kube_version: 1.34.1 }

This would also allow us to remove if: ${{ matrix.os.name == 'ubuntu' }} for capms which is duplicate as well, since this' already been specified in docker-bake.hcl.

Not sure though, if there are conflicts with version: having an array assigned as opposed to having only a number assigned 🤔

@vknabel vknabel force-pushed the build-capms-v1.33-and-v1.34 branch from ae3f8cd to 239450e Compare November 6, 2025 07:35
@vknabel
Copy link
Copy Markdown
Contributor Author

vknabel commented Nov 6, 2025

@mac641 good idea, but I'd vote for this to be a separate PR or issue as there is much more involved into this.
We also need to keep some complexities in mind like that capms images are built on top of ubuntu images.

@mac641
Copy link
Copy Markdown
Contributor

mac641 commented Nov 6, 2025

@mac641 good idea, but I'd vote for this to be a separate PR or issue as there is much more involved into this. We also need to keep some complexities in mind like that capms images are built on top of ubuntu images.

@vknabel Fair, let's do a separate PR.
Nonetheless, I'm curious: What complexities do you have in mind?
The dependency to ubuntu is specified in docker-bake.hcl and will be respected every time an image is build.

@vknabel vknabel added the keep branch Don't delete this branch, e.g. for future reference or when used in a deployment label Jan 7, 2026
@vknabel vknabel force-pushed the build-capms-v1.33-and-v1.34 branch from f757c59 to 7c91e63 Compare March 13, 2026 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

keep branch Don't delete this branch, e.g. for future reference or when used in a deployment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants