test(image-service): add tests for checkImageURL and fix issues encountered on the way

Author: mac641

cmd/metal-api/internal/service/image-service.go

@@ -5,8 +5,8 @@ import (
 	"fmt"
 	"log/slog"
 	"net/http"
-	"net/url"
 	"strconv"
+	"strings"
 	"time"
 
 	"github.com/metal-stack/metal-api/cmd/metal-api/internal/datastore"
@@ -351,12 +351,9 @@ func (r *imageResource) createImage(request *restful.Request, response *restful.
 }
 
 func checkImageURL(id, inputURL string, ociCredentials authn.Authenticator) error {
-	parsedURL, err := url.Parse(inputURL)
-	if err != nil {
-		return fmt.Errorf("image:%s with url:%s could not be parsed. error:%w", id, inputURL, err)
-	}
+	parsedURL := strings.Split(inputURL, "://")
 
-	switch parsedURL.Scheme {
+	switch parsedURL[0] {
 	case "http", "https":
 		res, err := http.Head(inputURL)
 		if err != nil {
@@ -366,7 +363,7 @@ func checkImageURL(id, inputURL string, ociCredentials authn.Authenticator) erro
 			return fmt.Errorf("image:%s is not accessible under:%s status:%s", id, inputURL, res.Status)
 		}
 	case "oci":
-		ref, err := name.ParseReference(inputURL)
+		ref, err := name.ParseReference(parsedURL[1])
 		if err != nil {
 			return fmt.Errorf("image reference:%s could not be parsed. error:%w", inputURL, err)
 		}
@@ -375,12 +372,12 @@ func checkImageURL(id, inputURL string, ociCredentials authn.Authenticator) erro
 			ociCredentials = authn.Anonymous
 		}
 
-		_, err = remote.Head(ref, remote.WithAuth(ociCredentials))
+		_, err = remote.Image(ref, remote.WithAuth(ociCredentials))
 		if err != nil {
 			return fmt.Errorf("image:%s is not accessible under:%s error:%w", id, inputURL, err)
 		}
 	default:
-		return fmt.Errorf("image:%s with url:%s has unkown protocol. error:%w", id, inputURL, err)
+		return fmt.Errorf("image:%s with url:%s has unkown protocol", id, inputURL)
 	}
 
 	return nil

cmd/metal-api/internal/service/image-service_test.go

@@ -108,6 +108,48 @@ func TestDeleteImage(t *testing.T) {
 	require.Equal(t, testdata.Img3.Name, *result.Name)
 }
 
+func TestCheckImageURL(t *testing.T) {
+	t.Run("Invalid URL", func(t *testing.T) {
+		err := checkImageURL("testID", "http://invalid-ürl", nil)
+		require.EqualError(t, err, "image:testID is not accessible under:http://invalid-ürl error:Head \"http://invalid-%C3%BCrl\": dial tcp: lookup xn--invalid-rl-heb: no such host")
+	})
+
+	t.Run("HTTP URL with successful HEAD request", func(t *testing.T) {
+		server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+			w.WriteHeader(http.StatusOK)
+		}))
+		defer server.Close()
+
+		err := checkImageURL("testID", server.URL, nil)
+		require.NoError(t, err)
+	})
+
+	t.Run("HTTP URL with unsuccessful HEAD request", func(t *testing.T) {
+		server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+			w.WriteHeader(http.StatusNotFound)
+		}))
+		defer server.Close()
+
+		err := checkImageURL("testID", server.URL, nil)
+		require.EqualError(t, err, "image:testID is not accessible under:"+server.URL+" status:404 Not Found")
+	})
+
+	t.Run("Unsupported scheme", func(t *testing.T) {
+		err := checkImageURL("testID", "ftp://unsupported.url", nil)
+		require.EqualError(t, err, "image:testID with url:ftp://unsupported.url has unkown protocol")
+	})
+
+	t.Run("valid OCI URL", func(t *testing.T) {
+		err := checkImageURL("testID", "oci://ghcr.io/metal-stack/debian:latest", nil)
+		require.NoError(t, err)
+	})
+
+	t.Run("OCI URL with invalid reference", func(t *testing.T) {
+		err := checkImageURL("testID", "oci://inva lid", nil)
+		require.EqualError(t, err, "image reference:oci://inva lid could not be parsed. error:could not parse reference: inva lid")
+	})
+}
+
 func TestCreateImage(t *testing.T) {
 	ds, mock := datastore.InitMockDB(t)
 	testdata.InitMockDBData(mock)