fixed the mac-ci failing for metacall_node_port_c_lib_test#773
Merged
viferga merged 1 commit intometacall:developfrom Apr 17, 2026
Merged
Conversation
Member
|
You made it, congratulations. It passes the macos tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Export
metacall_load_from_package_exto the node_port layer so C libraries can be loaded with all options (include paths, headers, libraries) in a single call. Fixes macOS CI failure where C loader couldn't be properly initialized through node_port.Testing
metacall-node-port-c-lib-testpassing (critical test)Details
The C loader requires
headersoption to discover and export symbols via libclang. Previous approach usingmetacall_execution_pathwas fragile on macOS. New approach passes all options at load time, ensuring symbols are properly discovered.Closes