SEARCH-680: Index genre annotations#136
Conversation
|
If you are using Local development of Search Index Rebuilder setup, then it is supposed to install requirements when starting the container, so just restarting the service |
|
I was just trying to run the script from a local clone of sir itself, nothing else :) |
|
Have you reinstalled the requirements? Otherwise it might be a problem with your running environment. |
|
I managed to generate these through the sir container :) So this should be fine, now, hopefully. |
yvanzo
left a comment
There was a problem hiding this comment.
The code changes look good but I didn’t test it either.
The reindex couldn’t work because of a bug in the commit dff0a11 it was based on. A fix for this bug is in master but it depends on code migrated to SQLAlchemy 1.4 and which isn’t production-ready yet. So as a workaround, this pull request can be based on the temporary branch released-master (which match the latest release v3.0.1) until master gets stabilized.
I confirm that no change is required in any other repository to make it work as genre will only appear in annotation core’s type field in MB Solr schema which is a free string.
8ab9d6b to
0c9cdc2
Compare
2576f1f to
4492dbc
Compare
|
Rebased this, and added a test for genre annotations (which passes). |
Implement SEARCH-680
AFAICT this is all that needs to be changed, except for generating new triggers and whatnot so that they check
genre_annotation. But I didn't manage to generate them locally with the command in a8798bc - dunno if that's changed or something is missing here (it complains aboutModuleNotFoundError: No module named 'sentry_sdk'but I also can't run setup properly, it seems, because then it complains aboutNo such file or directory: 'mbrng/__init__.py). Maybe someone else can generate them and squash?