Skip to content

SEARCH-680: Index genre annotations#136

Draft
reosarevok wants to merge 1 commit intometabrainz:masterfrom
reosarevok:SEARCH-680
Draft

SEARCH-680: Index genre annotations#136
reosarevok wants to merge 1 commit intometabrainz:masterfrom
reosarevok:SEARCH-680

Conversation

@reosarevok
Copy link
Copy Markdown
Member

@reosarevok reosarevok commented Jul 11, 2022

Implement SEARCH-680

AFAICT this is all that needs to be changed, except for generating new triggers and whatnot so that they check genre_annotation. But I didn't manage to generate them locally with the command in a8798bc - dunno if that's changed or something is missing here (it complains about ModuleNotFoundError: No module named 'sentry_sdk' but I also can't run setup properly, it seems, because then it complains about No such file or directory: 'mbrng/__init__.py). Maybe someone else can generate them and squash?

@yvanzo
Copy link
Copy Markdown
Contributor

yvanzo commented Jul 18, 2022

If you are using Local development of Search Index Rebuilder setup, then it is supposed to install requirements when starting the container, so just restarting the service indexer should do. If not, we would have to further investigate this issue.

@reosarevok
Copy link
Copy Markdown
Member Author

I was just trying to run the script from a local clone of sir itself, nothing else :)

@yvanzo
Copy link
Copy Markdown
Contributor

yvanzo commented Jul 18, 2022

Have you reinstalled the requirements? Otherwise it might be a problem with your running environment.

@reosarevok
Copy link
Copy Markdown
Member Author

I managed to generate these through the sir container :) So this should be fine, now, hopefully.

@yvanzo yvanzo marked this pull request as draft December 6, 2022 09:42
Copy link
Copy Markdown
Contributor

@yvanzo yvanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good but I didn’t test it either.

The reindex couldn’t work because of a bug in the commit dff0a11 it was based on. A fix for this bug is in master but it depends on code migrated to SQLAlchemy 1.4 and which isn’t production-ready yet. So as a workaround, this pull request can be based on the temporary branch released-master (which match the latest release v3.0.1) until master gets stabilized.

I confirm that no change is required in any other repository to make it work as genre will only appear in annotation core’s type field in MB Solr schema which is a free string.

@reosarevok reosarevok changed the base branch from master to released-master December 6, 2022 14:52
@reosarevok reosarevok changed the base branch from released-master to master June 20, 2025 12:44
@reosarevok
Copy link
Copy Markdown
Member Author

Rebased this, and added a test for genre annotations (which passes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants