SEARCH-452, SEARCH-677: Index all URL relationships and fix indexing disambiguation comments#135
Draft
yvanzo wants to merge 10 commits intometabrainz:masterfrom
Draft
SEARCH-452, SEARCH-677: Index all URL relationships and fix indexing disambiguation comments#135yvanzo wants to merge 10 commits intometabrainz:masterfrom
yvanzo wants to merge 10 commits intometabrainz:masterfrom
Conversation
It stays compatible with MMD schema 2.0 v-2020-11-12. Rebuilding the event index is needed to make it available.
It stays compatible with MMD schema 2.0 v-2020-11-12. Rebuilding the event index is needed to make it available.
Convert: - event-URL relationship - instrument-URL relationship - label-URL relationship - series-URL relationship - work-URL relationship All other URL relationships already have a conversion function.
Additionally to URL relationships to artists and releases, this patch indexes URL relationships to events, instruments, labels, places, recordings, release groups, series, and work, with the same data: gid, name, disambiguation comment if available, and video for recording. Rebuilding the url index is needed to make these available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
Solution
These two tickets are resolved together because they use the same functions in code behind the scenes.
Checklist for author
Action
On deployment: