Skip to content

feat added: QA pairs to generate by chunk size#88

Open
cneuralnetwork wants to merge 1 commit into
meta-llama:mainfrom
cneuralnetwork:main
Open

feat added: QA pairs to generate by chunk size#88
cneuralnetwork wants to merge 1 commit into
meta-llama:mainfrom
cneuralnetwork:main

Conversation

@cneuralnetwork
Copy link
Copy Markdown

Pull Request

Description

Implemented a new num_pairs_per_chunk parameter that scales QA generation based on the number of chunks in a document.
Overall -

  • Added num_pairs_per_chunk parameter to generate_qa_pairs() and process_documents()
  • Parameter priority: num_pairs_per_chunk takes precedence over num_pairs
  • Backward compatible: existing num_pairs usage continues to work unchanged

Old way (still functions):
synthetic-data-kit create document.txt --type qa --num-pairs 25
Result: 25 total pairs regardless of document size
New way:
synthetic-data-kit create document.txt --type qa --num-pairs-per-chunk 2
Result: 2 pairs per chunk
- 29 chunks = 58 pairs
- 200 chunks = 400 pairs

Tests

  • Added 3 new unit tests for per-chunk mode, priority logic, and integration
image

Fixes #63

Type of change

Please non-releavant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change
  • Documentation update

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Dec 15, 2025

Hi @cneuralnetwork!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Dec 15, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: QA pairs to generate by chunk size

1 participant