fix: update root dependencies and Python version floor#1042
Open
mattcarrollcode wants to merge 1 commit into
Open
fix: update root dependencies and Python version floor#1042mattcarrollcode wants to merge 1 commit into
mattcarrollcode wants to merge 1 commit into
Conversation
- markupsafe==2.0.1 -> >=2.1 (5-year-old pin, conflicts with Jinja2) - pyyaml==6.0.1 -> >=6.0.1 (remove exact pin blocking patches) - faiss-gpu -> faiss-cpu (faiss-gpu on PyPI is unmaintained) - requires-python >=3.8 -> >=3.10 (3.8 EOL Oct 2024, deps need 3.9+)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
markupsafe==2.0.1->>=2.1(5-year-old pin, conflicts with modern Jinja2)pyyaml==6.0.1->>=6.0.1(remove exact pin blocking security patches)faiss-gpu->faiss-cpu(faiss-gpu on PyPI is unmaintained)requires-python >=3.8->>=3.10(Python 3.8 EOL Oct 2024)Motivation
The exact
markupsafepin dates to 2021 and conflicts with many modern libraries.faiss-gpuon PyPI is no longer maintained for newer CUDA versions. Python 3.8 is end-of-life and the codebase already requires 3.10+ features.Test plan
pip install -e '.[tests]'succeeds on Python 3.10+pytest src/tests/passes