fix: harden email agent security (allowlist, pickle, exceptions)#1040
Open
mattcarrollcode wants to merge 1 commit into
Open
fix: harden email agent security (allowlist, pickle, exceptions)#1040mattcarrollcode wants to merge 1 commit into
mattcarrollcode wants to merge 1 commit into
Conversation
- Add ALLOWED_FUNCTIONS allowlist before globals() dispatch to prevent arbitrary code execution from LLM-crafted function names - Replace pickle-based token storage with JSON (google.oauth2.credentials) - Replace bare except: with except (json.JSONDecodeError, KeyError): - Fix type(result) == dict to isinstance(result, dict) - Update Google OAuth library version constraints
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ALLOWED_FUNCTIONSallowlist beforeglobals()dispatch to prevent arbitrary code execution from LLM-crafted function namespickle-based OAuth token storage with JSON (google.oauth2.credentials)except:withexcept (json.JSONDecodeError, KeyError):type(result) == dicttoisinstance(result, dict)Motivation
The
globals()[function_name]pattern dispatches to any function in the global scope based on LLM output. An adversarial prompt injection could cause execution of arbitrary functions.pickle.load()on token files is an arbitrary code execution vector.Test plan
email_agent.pypasses syntax check