fix: WhatsApp bot undefined var, hardcoded URL, wrong package#1039
Open
mattcarrollcode wants to merge 1 commit into
Open
fix: WhatsApp bot undefined var, hardcoded URL, wrong package#1039mattcarrollcode wants to merge 1 commit into
mattcarrollcode wants to merge 1 commit into
Conversation
- Replace undefined ACCESS_TOKEN with META_ACCESS_TOKEN (runtime crash) - Replace hardcoded ngrok URL with BASE_URL env var - Fix file handle leak in send_audio_message (double-open) - Remove wrong dotenv==0.9.9 package (python-dotenv already present)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ACCESS_TOKENwithMETA_ACCESS_TOKEN(runtime crash on line 59/72)BASE_URLenv varsend_audio_message(file opened twice)dotenv==0.9.9package (correctpython-dotenvalready listed)Motivation
send_audio_message()crashes at runtime becauseACCESS_TOKENis never defined — onlyMETA_ACCESS_TOKENis. A developer's ngrok URL was committed. ThedotenvPyPI package is notpython-dotenv.Test plan
webhook_utils.pyhas no references to undefined variables