fix: prevent credential leaks via .env files#1038
Open
mattcarrollcode wants to merge 1 commit into
Open
Conversation
- Add .env and .env.* to root .gitignore (with !.env.example exception) - Rename committed .env files to .env.example templates - Update WhatsApp bot README to reference .env.example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.envand.env.*to root.gitignore(with!.env.exampleexception).envfiles to.env.exampletemplates.env.exampleMotivation
Two
.envfiles with placeholder credentials were committed to git. The root.gitignorehad no.envexclusion, so users who fill in real keys would have credentials tracked in version control.Test plan
.envfiles are ignored by git after this change.env.examplefiles are visible and contain placeholder values