Feature/t5s3 epaper inkhud fixes#10287
Open
giannoug wants to merge 6 commits intomeshtastic:developfrom
Open
Conversation
…erge The merge of master into develop (fcb9ec0) added src/platform/extra_variants/t5s3_epaper/variant.cpp with the full board implementation (touch, readTouch, lateInitVariant), but a merge conflict left variants/esp32s3/t5s3_epaper/variant.cpp with its original full content too — causing multiple definition errors at link time. Reduce variants/esp32s3/t5s3_epaper/variant.cpp to only the two functions not present in extra_variants: earlyInitVariant() and variant_shutdown(), matching the pattern used by t-deck-pro. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Tested on device — 16px uniform margins look noticeably cleaner than the previous asymmetric 8–9px values. Canvas shrinks from 944×523 to 928×508 (H_OFFSET_BYTES=2, V_OFFSET_TOP/BOTTOM=16). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Fix keyboard navigation: map swipe LEFT/RIGHT to navLeft/navRight instead of navUp/navDown so horizontal cursor movement works in the on-screen keyboard (freeTextMode). Menu back and confirm via LEFT/RIGHT swipe; vertical scroll via UP/DOWN as before. - Fix joystick alignment ownership: remove dead pre-begin alignment assignment (overwritten by loadSettings); move it into post-begin enforcement block alongside enabled/aligned. Restore per-touch alignment update in TouchInkHUDBridge so rotation changes via the InkHUD menu self-heal on the next touch. - Lower TOUCH_THRESHOLD_X from 60 to 40: log analysis showed legitimate short swipes (~41px) being misclassified as taps. Threshold is now symmetric with TOUCH_THRESHOLD_Y to handle axis-swap on rotation changes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The GT911 touch controller reports a hardware home button via the haveKey bit in its point info register, surfaced through SensorLib's setHomeButtonCallback(). Wire this to inkhud->longpress() (open menu / back) with a 400ms debounce to suppress repeated callbacks while held. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ED047TC1 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
Bot
added
the
hardware-support
Contributor
Author
|
The PR title should be |
Contributor
|
I would advice submitting part of this PR once this other one is approved. We have already stablished plans for a full touch UI so some fixes here may be null. |
Contributor
Author
|
Sure, no problem. If there's a plan or general direction for this device I would like to help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
T5-S3-ePaper-Pro InkHUD: touch nav fixes, home button, margin cleanup
Fixes and improvements to the LilyGo T5-E-Paper-S3-Pro InkHUD port, all tested on hardware.
Touch navigation fixes
TouchInkHUDBridge: swipe-left/right in system applet context (menu, keyboard) was callingnavUp()/navDown()instead ofnavLeft()/navRight(). Fixed.TOUCH_THRESHOLD_Xreduced 60→40 to matchTOUCH_THRESHOLD_Y, improving horizontal swipe sensitivity.begin()so it is set alongside the other enforced joystick settings.GT911 hardware home button
Wires the GT911's physical home button to
InkHUD::longpress()viasetHomeButtonCallback(), giving users a dedicated button to open/close the menu. 400 ms debounce prevents multiple fires per press. InkHUD builds only.ED047TC1 display margins
Increased safe-area margins from ~8–9 px to 16 px on all sides (
H_OFFSET_BYTES1→2,V_OFFSET_TOP/BOTTOM9/8→16/16), ensuring content clears the panel's inactive border at all rotations. Safe area: 928×508 px (was 944×523). Removes theEINK_EDGE_LINEScalibration diagnostic left over from development.Duplicate symbol fix
The
fcb9ec0crefactor on develop moved T5S3 touch/InkHUD code tosrc/platform/extra_variants/. A merge left the old copy invariants/esp32s3/t5s3_epaper/variant.cpp, causing a link error. Removed the duplicate.Attempted: touch-to-wake from deep sleep (not included)
Investigated using GT911 INT (GPIO3, valid RTC GPIO) as an EXT1 wakeup source. Boot button (GPIO0) EXT1 works; GPIO3 does not, despite: leaving GT911 active (command
0x05is full host-controlled sleep), callingesp_sleep_enable_ext1_wakeup()last invariant_shutdown(), explicitrtc_gpio_init()+rtc_gpio_pullup_en(), and draining the touch buffer before sleep. Root cause unresolved — likely GT911 not asserting INT during host deep sleep (possibly a power rail issue). Deferred.A fix to
SensorLib'sGT911::sleep()(upstream leaves INT as OUTPUT LOW, blocking any future EXT1 wakeup) will be submitted to lewisxhe/SensorLib separately.🤝 Attestations