[pull] master from serde-rs:master#10
Open
pull[bot] wants to merge 726 commits intomesalock-linux:masterfrom
Open
[pull] master from serde-rs:master#10pull[bot] wants to merge 726 commits intomesalock-linux:masterfrom
pull[bot] wants to merge 726 commits intomesalock-linux:masterfrom
Conversation
Fixes #1125. error: expected item, found `"serde_json requires that either `std` (default) or `alloc` feature is enabled"` --> ~/.cargo/registry/src/index.crates.io-6f17d22bba15001f/serde_json-1.0.115/src/features_check/error.rs:1:1 | 1 | "serde_json requires that either `std` (default) or `alloc` feature is enabled" | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected item | = note: for a full list of items that can appear in modules, see <https://doc.rust-lang.org/reference/items.html> error[E0004]: non-exhaustive patterns: `Value::String(_)` not covered --> ~/.cargo/registry/src/index.crates.io-6f17d22bba15001f/serde_json-1.0.115/src/value/de.rs:216:15 | 216 | match self { | ^^^^ pattern `Value::String(_)` not covered | note: `Value` defined here --> ~/.cargo/registry/src/index.crates.io-6f17d22bba15001f/serde_json-1.0.115/src/value/mod.rs:116:10 | 116 | pub enum Value { | ^^^^^ ... 151 | String(String), | ------ not covered = note: the matched value is of type `Value` help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern or an explicit pattern as shown | 223 ~ Value::Object(v) => visit_object(v, visitor), 224 ~ Value::String(_) => todo!(), | error[E0004]: non-exhaustive patterns: `Cow::Owned(_)` not covered --> ~/.cargo/registry/src/index.crates.io-6f17d22bba15001f/serde_json-1.0.115/src/value/de.rs:1338:15 | 1338 | match self.value { | ^^^^^^^^^^ pattern `Cow::Owned(_)` not covered | note: `Cow<'_, str>` defined here --> /rustc/98aa3624be70462d6a25ed5544333e3df62f4c66/library/alloc/src/borrow.rs:180:1 ::: /rustc/98aa3624be70462d6a25ed5544333e3df62f4c66/library/alloc/src/borrow.rs:190:5 | = note: not covered = note: the matched value is of type `Cow<'_, str>` help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern or an explicit pattern as shown | 1339 ~ Cow::Borrowed(string) => visitor.visit_borrowed_str(string), 1340 ~ Cow::Owned(_) => todo!(), | error[E0004]: non-exhaustive patterns: `&Value::Object(_)` not covered --> ~/.cargo/registry/src/index.crates.io-6f17d22bba15001f/serde_json-1.0.115/src/value/ser.rs:17:15 | 17 | match self { | ^^^^ pattern `&Value::Object(_)` not covered | note: `Value` defined here --> ~/.cargo/registry/src/index.crates.io-6f17d22bba15001f/serde_json-1.0.115/src/value/mod.rs:116:10 | 116 | pub enum Value { | ^^^^^ ... 175 | Object(Map<String, Value>), | ------ not covered = note: the matched value is of type `&Value` help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern or an explicit pattern as shown | 22 ~ Value::Array(v) => v.serialize(serializer), 23 ~ &Value::Object(_) => todo!(), |
warning: unexpected `cfg` condition name: `limb_width_32`
--> src/lexical/mod.rs:31:7
|
31 | #[cfg(limb_width_32)]
| ^^^^^^^^^^^^^
|
= help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, `windows`
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_32)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
= note: `#[warn(unexpected_cfgs)]` on by default
warning: unexpected `cfg` condition name: `limb_width_64`
--> src/lexical/mod.rs:34:7
|
34 | #[cfg(limb_width_64)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_64)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_32`
--> src/lexical/large_powers.rs:5:7
|
5 | #[cfg(limb_width_32)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_32)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_64`
--> src/lexical/large_powers.rs:8:7
|
8 | #[cfg(limb_width_64)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_64)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_32`
--> src/lexical/math.rs:40:7
|
40 | #[cfg(limb_width_32)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_32)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_32`
--> src/lexical/math.rs:43:7
|
43 | #[cfg(limb_width_32)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_32)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_32`
--> src/lexical/math.rs:46:7
|
46 | #[cfg(limb_width_32)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_32)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_32`
--> src/lexical/math.rs:49:7
|
49 | #[cfg(limb_width_32)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_32)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_64`
--> src/lexical/math.rs:53:7
|
53 | #[cfg(limb_width_64)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_64)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_64`
--> src/lexical/math.rs:56:7
|
56 | #[cfg(limb_width_64)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_64)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_64`
--> src/lexical/math.rs:59:7
|
59 | #[cfg(limb_width_64)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_64)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_64`
--> src/lexical/math.rs:62:7
|
62 | #[cfg(limb_width_64)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_64)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_32`
--> src/lexical/math.rs:82:7
|
82 | #[cfg(limb_width_32)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_32)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_64`
--> src/lexical/math.rs:89:7
|
89 | #[cfg(limb_width_64)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_64)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_32`
--> src/lexical/small_powers.rs:6:7
|
6 | #[cfg(limb_width_32)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_32)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_32`
--> src/lexical/small_powers.rs:12:7
|
12 | #[cfg(limb_width_32)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_32)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_64`
--> src/lexical/small_powers.rs:18:7
|
18 | #[cfg(limb_width_64)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_64)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_32`
--> tests/../src/lexical/mod.rs:31:7
|
31 | #[cfg(limb_width_32)]
| ^^^^^^^^^^^^^
|
= help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, `windows`
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_32)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
= note: `#[warn(unexpected_cfgs)]` on by default
warning: unexpected `cfg` condition name: `limb_width_64`
--> tests/../src/lexical/mod.rs:34:7
|
34 | #[cfg(limb_width_64)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_64)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_32`
--> tests/../src/lexical/large_powers.rs:5:7
|
5 | #[cfg(limb_width_32)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_32)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_64`
--> tests/../src/lexical/large_powers.rs:8:7
|
8 | #[cfg(limb_width_64)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_64)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_32`
--> tests/../src/lexical/math.rs:40:7
|
40 | #[cfg(limb_width_32)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_32)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_32`
--> tests/../src/lexical/math.rs:43:7
|
43 | #[cfg(limb_width_32)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_32)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_32`
--> tests/../src/lexical/math.rs:46:7
|
46 | #[cfg(limb_width_32)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_32)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_32`
--> tests/../src/lexical/math.rs:49:7
|
49 | #[cfg(limb_width_32)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_32)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_64`
--> tests/../src/lexical/math.rs:53:7
|
53 | #[cfg(limb_width_64)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_64)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_64`
--> tests/../src/lexical/math.rs:56:7
|
56 | #[cfg(limb_width_64)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_64)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_64`
--> tests/../src/lexical/math.rs:59:7
|
59 | #[cfg(limb_width_64)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_64)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_64`
--> tests/../src/lexical/math.rs:62:7
|
62 | #[cfg(limb_width_64)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_64)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_32`
--> tests/../src/lexical/math.rs:82:7
|
82 | #[cfg(limb_width_32)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_32)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_64`
--> tests/../src/lexical/math.rs:89:7
|
89 | #[cfg(limb_width_64)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_64)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_32`
--> tests/../src/lexical/small_powers.rs:6:7
|
6 | #[cfg(limb_width_32)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_32)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_32`
--> tests/../src/lexical/small_powers.rs:12:7
|
12 | #[cfg(limb_width_32)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_32)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_64`
--> tests/../src/lexical/small_powers.rs:18:7
|
18 | #[cfg(limb_width_64)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_64)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_32`
--> tests/lexical/math.rs:21:7
|
21 | #[cfg(limb_width_32)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_32)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
warning: unexpected `cfg` condition name: `limb_width_64`
--> tests/lexical/math.rs:26:7
|
26 | #[cfg(limb_width_64)]
| ^^^^^^^^^^^^^
|
= help: consider using a Cargo feature instead or adding `println!("cargo::rustc-check-cfg=cfg(limb_width_64)");` to the top of the `build.rs`
= note: see <https://doc.rust-lang.org/nightly/cargo/reference/build-scripts.html#rustc-check-cfg> for more information about checking conditional configuration
Resolve unexpected_cfgs warning
These can now be replaced with a direct call to the Deserializer impl on Map (or &Map, as applicable).
Rely on docs.rs to define --cfg=docsrs by default
warning: unnecessary hashes around raw string literal
--> tests/test.rs:2313:16
|
2313 | assert_eq!(r#"42"#, array_from_str[1].get());
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_string_hashes
= note: `-W clippy::needless-raw-string-hashes` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::needless_raw_string_hashes)]`
help: remove all the hashes around the string literal
|
2313 - assert_eq!(r#"42"#, array_from_str[1].get());
2313 + assert_eq!(r"42", array_from_str[1].get());
|
warning: unnecessary hashes around raw string literal
--> tests/test.rs:2315:16
|
2315 | assert_eq!(r#"null"#, array_from_str[3].get());
| ^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_string_hashes
help: remove all the hashes around the string literal
|
2315 - assert_eq!(r#"null"#, array_from_str[3].get());
2315 + assert_eq!(r"null", array_from_str[3].get());
|
warning: unnecessary hashes around raw string literal
--> tests/test.rs:2392:16
|
2392 | assert_eq!(r#"42"#, array_from_str[1].get());
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_string_hashes
help: remove all the hashes around the string literal
|
2392 - assert_eq!(r#"42"#, array_from_str[1].get());
2392 + assert_eq!(r"42", array_from_str[1].get());
|
warning: unnecessary hashes around raw string literal
--> tests/test.rs:2394:16
|
2394 | assert_eq!(r#"null"#, array_from_str[3].get());
| ^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_string_hashes
help: remove all the hashes around the string literal
|
2394 - assert_eq!(r#"null"#, array_from_str[3].get());
2394 + assert_eq!(r"null", array_from_str[3].get());
|
warning: unnecessary hashes around raw string literal
--> tests/test.rs:2399:16
|
2399 | assert_eq!(r#"42"#, array_from_reader[1].get());
| ^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_string_hashes
help: remove all the hashes around the string literal
|
2399 - assert_eq!(r#"42"#, array_from_reader[1].get());
2399 + assert_eq!(r"42", array_from_reader[1].get());
|
warning: unnecessary hashes around raw string literal
--> tests/test.rs:2401:16
|
2401 | assert_eq!(r#"null"#, array_from_reader[3].get());
| ^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_string_hashes
help: remove all the hashes around the string literal
|
2401 - assert_eq!(r#"null"#, array_from_reader[3].get());
2401 + assert_eq!(r"null", array_from_reader[3].get());
|
warning: digit groups should be smaller
--> tests/test.rs:962:9
|
962 | 51.24817837550540_4, // 51.2481783755054_1
| ^^^^^^^^^^^^^^^^^^^ help: consider: `51.248_178_375_505_404`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups
= note: `-W clippy::large-digit-groups` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::large_digit_groups)]`
warning: digit groups should be smaller
--> tests/test.rs:963:10
|
963 | -93.3113703768803_3, // -93.3113703768803_2
| ^^^^^^^^^^^^^^^^^^ help: consider: `93.311_370_376_880_33`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups
warning: digit groups should be smaller
--> tests/test.rs:964:10
|
964 | -36.5739948427534_36, // -36.5739948427534_4
| ^^^^^^^^^^^^^^^^^^^ help: consider: `36.573_994_842_753_436`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups
warning: digit groups should be smaller
--> tests/test.rs:965:9
|
965 | 52.31400820410624_4, // 52.31400820410624_
| ^^^^^^^^^^^^^^^^^^^ help: consider: `52.314_008_204_106_244`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups
warning: digit groups should be smaller
--> tests/test.rs:966:9
|
966 | 97.4536532003468_5, // 97.4536532003468_4
| ^^^^^^^^^^^^^^^^^^ help: consider: `97.453_653_200_346_85`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_digit_groups
warning: associated constant `NEGATIVE_INFINITY_BITS` is never used
--> src/lexical/num.rs:223:11
|
175 | pub trait Float: Number {
| ----- associated constant in this trait
...
223 | const NEGATIVE_INFINITY_BITS: Self::Unsigned;
| ^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
warning: associated constant `SIGN_MASK` is never used
--> src/lexical/num.rs:210:11
|
175 | pub trait Float: Number {
| ----- associated constant in this trait
...
210 | const SIGN_MASK: Self::Unsigned;
| ^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Implemented serde::de::Visitor::visit_i128. This fixes compatability with Ipld::Integer when using DagJsonCodec.
impl `Hash` for `Value`
warning: consider adding a `;` to the last statement for consistent formatting
--> src/map.rs:377:9
|
377 | self.map.hash(state)
| ^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `self.map.hash(state);`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
= note: `-W clippy::semicolon-if-nothing-returned` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::semicolon_if_nothing_returned)]`
Required since version 2.12.0 of indexmap.
Signed-off-by: claudecodering <claudecoder@outlook.com>
warning: this could be rewritten as `let...else`
--> src/lexical/algorithm.rs:54:9
|
54 | / let value = match mantissa.checked_mul(power) {
55 | | None => return None,
56 | | Some(value) => value,
57 | | };
| |__________^ help: consider writing: `let Some(value) = mantissa.checked_mul(power) else { return None };`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_let_else
= note: `-W clippy::manual-let-else` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::manual_let_else)]`
riscv64 also has an ilp32 variant[1][2]. [1] https://github.com/ruyisdk/riscv-gnu-toolchain-rv64ilp32 [2] https://fedoraproject.org/wiki/Architectures/RISC-V/64ILP32
Set fast_arithmetic=64 for riscv64
Switch from ryu -> zmij for float formatting
Align `arbitrary_precision` number strings with zmij’s formatting
warning: this `map_or` can be simplified
--> src/number.rs:123:28
|
123 | return self.n.parse::<f64>().ok().map_or(false, f64::is_finite);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or
= note: `-W clippy::unnecessary-map-or` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::unnecessary_map_or)]`
help: use `is_some_and` instead
|
123 - return self.n.parse::<f64>().ok().map_or(false, f64::is_finite);
123 + return self.n.parse::<f64>().ok().is_some_and(f64::is_finite);
|
Fixed in nightly-2026-02-13.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )