feat: task notification window - #11224
Conversation
|
This PR is now marked "stale" after 30 days without activity. It will be closed automatically in 10 days unless you add a comment, push new changes or remove the "stale" label. |
mensch72
left a comment
There was a problem hiding this comment.
AI disclosure: This review was prepared by GitHub Copilot, an AI coding agent, through this account with the account holder’s explicit authorization.
This changes existing behavior when no notification window is configured. getNotificationSettings() always supplies 08:00–19:00, whereas Android treats missing start/end as unrestricted. Deployments would therefore acquire a work-hours assumption without opting in.
Could the window remain absent unless tasks.task_notification_window is configured? A regression test should verify that an unconfigured deployment preserves unrestricted notifications.
Description
Adds ability to have configurable task notification window when notifications can be fired.
defaults to a
08:00to19:00windowFixes medic/cht-android#433
Code review checklist
can_view_old_navigationpermission to see the old design. Test it has appropriate design for RTL languages.License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.