fix(#11184): update task filter UI to match reports filter#11193
Conversation
|
@mrjones-plip The "Compile the app" failure is a CI infrastructure issue |
mrjones-plip
left a comment
There was a problem hiding this comment.
@santhosh-7777 thanks for the PR!
Please:
- update your branch with most recent changes from
master. I see your branch is out of date - manually confirm you code changes work. When I load your branch locally nothing has changed.
- make sure your tests actually test what you changed. Your test now checks for a
labelso the tests passes, but it does not actually test that the form uses a radio box.
To this end, please provide a short 5-10 second video showing you've successfully implemented the requested changes on the three filter UIs. This will save the time of the reviewer before they start to look at the code.
|
@mrjones-plip Added a short demo video showing the three UI changes working (radio buttons for Due date, single-select behavior, Apply button on mobile view, and Reset label). |
Community.Health.Toolkit.-.Google.Chrome.2026-06-19.12-51-56.mp4 |
There was a problem hiding this comment.
Thanks @santhosh-7777 ! Can you make the radio button values not bold (#1)? As well, it appears maybe "place" is missing (#2)?
|
@mrjones-plip Fixed the bold styling on radio button labels (#1). For the Place filter (#2) , this is existing behavior controlled by *ngIf="showPlaceFilter" which calls hasMultiplePlaces(). It only shows when the user has multiple facilities. In my demo video the test user only had one facility (Test District), so Place was correctly hidden. |
mrjones-plip
left a comment
There was a problem hiding this comment.
Thanks for the explanation about the missing place.
see request about moving CSS deceleration.
| [class.selected]="filter?.selected.has(status)" | ||
| [class.disabled]="disabled"> | ||
| <label> | ||
| <label style="font-weight: normal;"> |
There was a problem hiding this comment.
thanks for this fix! I don't see any inline styles in any of the cht-core/webapp/src/ts/* files - can you please move this change to the appropriate file in cht-core/webapp/src/css/*?
Thanks!
There was a problem hiding this comment.
Moved the font-weight: normal style from inline HTML to the label block in webapp/src/css/sidebar-filter.less as requested.
|
@mrjones-plip i have made requested changes could u please review . happy to make if changes are needed. thank you! |
mrjones-plip
left a comment
There was a problem hiding this comment.
Thanks @santhosh-7777 - LGTM
Description
Updated the task filter UI to match the existing reports filter UI.
Fixes #11184
Changes made:
Code review checklist