Chrome 140 added ReadableStreamBYOBReader options.min#27156
Merged
Chrome 140 added ReadableStreamBYOBReader options.min#27156
options.min#27156Conversation
… Chrome 140 The read() method of ReadableStreamBYOBReader was introduced in Chrome 89, but the options.min parameter was not fully supported or reliable until Chrome 140. This change marks full support for options.min parameter in 140. Also mirrors this change to Edge and Chrome for Android.
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
caugner
requested changes
Jun 27, 2025
Contributor
caugner
left a comment
There was a problem hiding this comment.
Thanks, LGTM overall.
Please see the failing check:
Status - 1 problem (1 error, 0 warnings):
✖ api.ReadableStreamBYOBReader.read.options_min_parameter - Error → Experimental should be set to false as the feature is supported in multiple browser engines.
◆ Tip: Run npm run fix to fix this problem automatically
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
Contributor
Author
Thank you for the review Claas, The feature initially landed in 139 but was only enabled as experimental. In Chrome 140, it’s promoted to stable, so I think it makes more sense to mark it as 140 rather than 139? Please let me know if that's ok Thanks. |
options.min
caugner
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The read() method of ReadableStreamBYOBReader was introduced in Chrome 89, but the options.min parameter was not fully supported until Chrome 140.
This change marks full support for options.min parameter in 140. Also mirrors this change to Edge and Chrome for Android.
Test results and supporting details
Related issues