Skip to content

No sign bit in uflt12f JavaScript decoder - #901

Open
jlesech wants to merge 1 commit into
mcci-catena:masterfrom
jlesech:master
Open

No sign bit in uflt12f JavaScript decoder#901
jlesech wants to merge 1 commit into
mcci-catena:masterfrom
jlesech:master

Conversation

@jlesech

@jlesech jlesech commented Aug 27, 2022

Copy link
Copy Markdown

Fix the uflt12f JavaScript decoder in README.

@terrillmoore

Copy link
Copy Markdown
Member

The uflt12f decoder is for unsigned floats, to save bits for values like relative humidity that can't physically take negative values. That's why the name begins with u. So this change is really not applicable. Also, sSign (where it was added in the patch), is it not in scope in the local the function, and will either cause a runtime error or will cause the sign to be set by unrelated global data.

The custom in this project is to put unrelated changes in different PRs, so the abp feather changes should be a different PR. Thanks!

@jlesech

jlesech commented Aug 27, 2022

Copy link
Copy Markdown
Author

I understand the goal of the uflt12f decoder :) But the goal of my PR is to remove it the sSign variable, not add it.

Sorry for the unrelated change, I did a mistake on my master branch. I removed the unrelated commit and I created another PR for the example sketch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants