This repository was archived by the owner on Nov 22, 2021. It is now read-only.
Remove duplicate tags on paste#826
Open
stehlikio wants to merge 1 commit into
Open
Conversation
|
Any chance this could be released? :) |
|
+1 to have this merged in. @mbenford any plans? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently ran into this and saw issue #795. It's a decent workaround, but a more permanent fix might be helpful.
It looks like when adding all of the tags from the paste, since everything is running async, the tags aren't present in the items array at the time of the duplicate check. We can get in front of this issue by removing duplicates from the split text before we try to insert duplicate values and have to check later down the road.