Bump to 6.10.1 minimum#14366
Conversation
* 6.10.0 does not compile anymore due to ABI breaks in QVideoTextureHelper Signed-off-by: Ryan Friedman <25047695+Ryanf55@users.noreply.github.com>
|
|
||
| # TODO: Remove qt_version override once aqtinstall supports Qt 6.10.1+ for cross-compiled ARM64 | ||
| # Workaround: Pin to Qt 6.10.0 until aqtinstall fix is released | ||
| # Tracking: https://github.com/miurahr/aqtinstall/pull/952 |
There was a problem hiding this comment.
This is now merged.
|
Windows build is broken by this. Not sure on fix yet, suggestions welcome. |
Problem is this hasn't been included in a release yet (miurahr/aqtinstall#952). I think we could build from a commit on their master branch though if we wanted to |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #14366 +/- ##
=========================================
Coverage ? 25.47%
=========================================
Files ? 769
Lines ? 65911
Branches ? 30495
=========================================
Hits ? 16791
Misses ? 37281
Partials ? 11839
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Build ResultsPlatform Status
Some builds failed. Pre-commit
Pre-commit hooks: 4 passed, 45 failed, 7 skipped. Test Resultslinux-coverage: 90 passed, 0 skipped Code Coverage
Artifact Sizes
Updated: 2026-05-12 18:23:14 UTC • Triggered by: Android |
|
@HTRamsey Is there a reason we won't lock down to a specific Qt version? To me not doing that just gives us possible support problems like this. The version we build with in CI is the only one that matters. Anything else is unverified. |
|
My plan was to raise the minimum for the release. It was kinda annoying raising the minimum on daily and having different branches on different versions and having to rebase all of them. But we can do it now too, doesn't matter that much |
|
Not quite sure what the problem is you are describing but as I've said before anything other than specific lockdown only causes support problems given my experience. I think it should always be locked down to a specific version. |
Description
Type of Change
Testing
Platforms Tested
Flight Stacks Tested
Screenshots
Checklist
Related Issues
By submitting this pull request, I confirm that my contribution is made under the terms of the project's dual license (Apache 2.0 and GPL v3).