Skip to content

VideoManager: Remove unused/incorrect override#14365

Open
Ryanf55 wants to merge 1 commit into
mavlink:masterfrom
ThinkOrbital:hotfix-incorrect-override
Open

VideoManager: Remove unused/incorrect override#14365
Ryanf55 wants to merge 1 commit into
mavlink:masterfrom
ThinkOrbital:hotfix-incorrect-override

Conversation

@Ryanf55
Copy link
Copy Markdown
Contributor

@Ryanf55 Ryanf55 commented May 12, 2026

Description

Fixes a compilation error on Ubuntu 22 introduced by #14332.
This function is not used in the codebase, so it can just be removed.

/home/ryan/Dev/qgroundcontrol/src/VideoManager/VideoReceiver/GStreamer/HwBuffers/GstDmaBufVideoBuffer.h:27:10: error: ‘bool GstDmaBufVideoBuffer::isDmaBuf() const’ marked ‘override’, but does not override
   27 |     bool isDmaBuf() const override { return true; }

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)
  • CI/Build changes
  • Other

Testing

  • Tested locally
  • Added/updated unit tests
  • Tested with simulator (SITL)
  • Tested with hardware

Platforms Tested

  • Linux
  • Windows
  • macOS
  • Android
  • iOS

Flight Stacks Tested

  • PX4
  • ArduPilot

Screenshots

Checklist

  • I have read the Contribution Guidelines
  • I have read the Code of Conduct
  • My code follows the project's coding standards
  • I have added tests that prove my fix/feature works
  • New and existing unit tests pass locally

Related Issues


By submitting this pull request, I confirm that my contribution is made under the terms of the project's dual license (Apache 2.0 and GPL v3).

Signed-off-by: Ryan Friedman <25047695+Ryanf55@users.noreply.github.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@b59e589). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #14365   +/-   ##
=========================================
  Coverage          ?   25.39%           
=========================================
  Files             ?      768           
  Lines             ?    65910           
  Branches          ?    30495           
=========================================
  Hits              ?    16738           
  Misses            ?    37361           
  Partials          ?    11811           
Flag Coverage Δ
unittests 25.39% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b59e589...b423d92. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

Build Results

Platform Status

Platform Status Details
Linux Passed View
Windows Passed View
MacOS Passed View
Android Passed View

All builds passed.

Pre-commit

Check Status Details
pre-commit Failed (non-blocking) View

Pre-commit hooks: 4 passed, 45 failed, 7 skipped.

Test Results

linux-coverage: 90 passed, 0 skipped
Total: 90 passed, 0 skipped

Code Coverage

Coverage Baseline Change
59.2% 59.2% -0.0%

Artifact Sizes

Artifact Size Δ from master
QGroundControl 216.85 MB -4.63 MB (decrease)
QGroundControl-aarch64 176.76 MB -0.01 MB (decrease)
QGroundControl-installer-AMD64 134.72 MB +0.03 MB (increase)
QGroundControl-installer-AMD64-ARM64 77.32 MB -0.01 MB (decrease)
QGroundControl-installer-ARM64 106.04 MB -0.00 MB (decrease)
QGroundControl-linux 335.18 MB +0.03 MB (increase)
QGroundControl-mac 187.14 MB +0.02 MB (increase)
QGroundControl-windows 187.15 MB +0.02 MB (increase)
QGroundControl-x86_64 171.95 MB -0.46 MB (decrease)
Total size decreased by 5.02 MB

Updated: 2026-05-12 17:09:54 UTC • Triggered by: Android

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant