mavros: validate plugin list patterns

[apples-kksk]

Requested

Issue #2024 reports that plugin_allowlist accepts garbage input without reporting an error.

Implemented

• Validate plugin_allowlist and plugin_denylist patterns against declared plugin classes before loading plugins.
• Preserve existing glob matching behavior for valid exact and wildcard patterns.
• Add unit coverage for valid patterns and invalid allowlist/denylist values.

Not covered

No changes to plugin loading order or plugin implementations.

Validated

• git diff --check HEAD~1..HEAD
• Attempted cmake -S mavros -B /tmp/mavros-2024-cmake-check, but this environment is missing ament_cmake.

colcon and ament_uncrustify are not available in the current environment.

[vooon]

I think it's a bad idea crashing if something in a list doesn't match.
I think better just to emit warning.

[apples-kksk]

Updated, thanks for the review.\n\n- Rebased the branch so the #2189 executor-thread changes are no longer included in this PR.\n- Changed unmatched plugin allow/deny patterns to emit a warning instead of throwing/crashing.\n\nI also checked the final PR diff: it now only touches mavros/src/lib/mavros_uas.cpp.

[vooon]

Now looks good, but why not to use lambda?

[apples-kksk]

No strong reason. I used a small named helper to keep the startup block readable and reuse the same logic for both plugin_allowlist and plugin_denylist.

A local lambda would work too; I can switch to that if you prefer.

[vooon]

Yes, it likely be cleaner.

[vooon]

Please do uncrustify: https://github.com/mavlink/mavros/blob/ros2/CONTRIBUTING.md

[apples-kksk]

Applied the uncrustify formatting in 9966b4b. Thanks.