Fix macos build#111
Conversation
|
@matsen Can you try if this branch fixes the build on your macOS? It's not including the BCR code, I'll make another action with libtorch if this succeeds. |
|
🤖 Tested on macOS — build succeeds, no regressions. Environment
BuildAll 109/109 targets compiled successfully with no errors. Only benign linker warnings: All four executables were produced: Tests (non-slow, run individually)Ran every non-slow test (89 tests) one at a time on both
The 26 segfaults and 8 assertion failures are all pre-existing on Passing tests include: DAG loader, overlay, compact genome, sample tree, RF distance, parsimony, weight accumulator, weight counter, S5F likelihood, Sankoff (all 4), SPR (4 of 7), merge (0 of 5), netam kmer/model/likelihood, mat conversion, mat view, parallel, UA-free parsimony, and more. |
|
@matsen It should be buildable with BCR and libtorch too: easiest should be to activate the conda environment environment-dev-macos-netam.yml If it builds for you we can merge. |
|
🤖 Build test on macOS Apple Silicon (M-series, macOS 15.5 Sequoia, AppleClang 17.0)Compilation: PASS
Tests: 86/89 non-slow tests passThe 3 failures are pre-existing on
Protobuf caveatInitial builds segfaulted on every protobuf parse operation. Root cause: homebrew protobuf 29.3 has a bug in Conda environment: Does not resolve on arm64The BCR + libtorch build: Not tested
Recommendations
|
This adds a Github CI action for macOS, and fixes some building issues.