Skip to content

Mark some of the indices in olm/megolm messages as required - #405

Open
poljar wants to merge 1 commit into
mainfrom
poljar/remove-encode-manual
Open

Mark some of the indices in olm/megolm messages as required#405
poljar wants to merge 1 commit into
mainfrom
poljar/remove-encode-manual

Conversation

@poljar

@poljar poljar commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

This ensures that the fields won't be omitted if they contain the default value 0.

This removes the need for our custom encode_manual methods while retaining libolm compatibility.

Took a while before coming back to this.

@poljar
poljar requested a review from dkasak as a code owner August 25, 2026 14:09
@codecov-commenter

codecov-commenter commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.63%. Comparing base (cfc4eee) to head (562e055).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
- Coverage   91.72%   91.63%   -0.09%     
==========================================
  Files          40       40              
  Lines        5533     5475      -58     
  Branches     5533     5475      -58     
==========================================
- Hits         5075     5017      -58     
  Misses        287      287              
  Partials      171      171              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codspeed-hq

codspeed-hq Bot commented Aug 25, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 6 untouched benchmarks


Comparing poljar/remove-encode-manual (562e055) with main (cfc4eee)

Open in CodSpeed

This ensures that the fields won't be omitted if they contain the
default value 0.

This removes the need for our custom encode_manual methods while
retaining libolm compatibility.

Took a while before coming back to this.
@poljar
poljar force-pushed the poljar/remove-encode-manual branch from b8acff9 to 562e055 Compare August 26, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants