Mark some of the indices in olm/megolm messages as required - #405
Open
poljar wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #405 +/- ##
==========================================
- Coverage 91.72% 91.63% -0.09%
==========================================
Files 40 40
Lines 5533 5475 -58
Branches 5533 5475 -58
==========================================
- Hits 5075 5017 -58
Misses 287 287
Partials 171 171 ☔ View full report in Codecov by Harness. |
This ensures that the fields won't be omitted if they contain the default value 0. This removes the need for our custom encode_manual methods while retaining libolm compatibility. Took a while before coming back to this.
poljar
force-pushed
the
poljar/remove-encode-manual
branch
from
August 26, 2026 14:29
b8acff9 to
562e055
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that the fields won't be omitted if they contain the default value 0.
This removes the need for our custom encode_manual methods while retaining libolm compatibility.
Took a while before coming back to this.