Skip to content

Ask for permission for using uploaded files in issue template#96

Merged
shyuep merged 1 commit into
materialsproject:mainfrom
DanielYang59:add-permission-clause
Jul 20, 2026
Merged

Ask for permission for using uploaded files in issue template#96
shyuep merged 1 commit into
materialsproject:mainfrom
DanielYang59:add-permission-clause

Conversation

@DanielYang59

@DanielYang59 DanielYang59 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

I'm by no means a lawyer, but I think users retain ownership of their uploaded files and pmg might not automatically have the right to add their files to the test suite just because users provided a file during bug report? Previously I have to manually ask the user for permission which was a bit tedious

@DanielYang59
DanielYang59 requested a review from shyuep as a code owner July 20, 2026 09:28
@shyuep

shyuep commented Jul 20, 2026

Copy link
Copy Markdown
Member

🤖 Automated PR review generated by Claude, posted on behalf of @shyuep.

Sensible, low-risk change — adds an explicit licensing checkbox to the bug-report template so maintainers can add uploaded reproduction files to the test suite with clear permission. Non-code change; lint passes.

Nit: the checkbox is intentionally optional (no required), which is correct since it only applies when a file is actually uploaded. Wording is clear. LGTM.

@shyuep
shyuep merged commit 03b9d57 into materialsproject:main Jul 20, 2026
1 check passed
@DanielYang59
DanielYang59 deleted the add-permission-clause branch July 21, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants