Skip to content

Fix for Thread.create issue with Haxe nightlies #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexHaxe wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fix for Thread.create issue with Haxe nightlies #188

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d0f6e26
fixed thread API change in Haxe nightlies
AlexHaxe Dec 19, 2020
5a1eea8
added missing lix dependencies
AlexHaxe Dec 19, 2020
0674233
reverted lix dependecies
AlexHaxe Dec 19, 2020
4f380f5
fixed Haxe 3.4.7 compile error with version check
AlexHaxe Dec 19, 2020
edea4ba
fixed Std.is deprecation warnings introduced in Haxe 4.1.0
AlexHaxe Dec 20, 2020
6459529
renamed isTypeof to isOfType
AlexHaxe Dec 20, 2020
81e9d43
replaced @:enum abstract with enum abstract
AlexHaxe Apr 18, 2023
5d96424
fixed StackItem error on nightly
AlexHaxe Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/massive/munit/TestRunner.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,11 @@ class TestRunner implements IAsyncDelegateObserver

#if (neko || cpp || java || hl || eval)
var self = this;
var runThread:Thread = Thread.create(function()
var createThread = Thread.create;
#if (haxe4 && (haxe >= version("4.2.0-rc.1")))

@SlavaRa SlavaRa Dec 19, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not #if (haxe >= version("4.2.0-rc.1"))?

@SlavaRa SlavaRa Dec 19, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mb?

var createThread = #if (haxe >= version("4.2.0-rc.1")) Thread.createWithEventLoop #else Thread.create #end;

@AlexHaxe AlexHaxe Dec 19, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to break compatibility with Haxe 3, version("x.x.x") is a Haxe 4 feature

@AlexHaxe AlexHaxe Dec 19, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that being said... I should have tested with Haxe 3, which makes a bit more ugly. I had to split the conditionals to make it work.

createThread = Thread.createWithEventLoop;
#end
var runThread:Thread = createThread(function()
{
self.execute();
while (self.running)
Expand Down