feat(tests): use mason.nvim v2#17
Merged
Merged
Conversation
Member
Author
|
Tested it on williamboman/mason-registry-playground#80 |
chrisgrieser
reviewed
Aug 1, 2025
| for __, pkg_path in ipairs(packages) do | ||
| local pkg = try(parse_package_spec(pkg_path)) | ||
| -- Turns "packages/rust-analyzer/package.yaml" into "rust-analyzer" | ||
| local pkg_name = vim.fn.fnamemodify(pkg_path, ":h:t") |
Member
There was a problem hiding this comment.
For code readability, this could also be achieved with vim.fs.basename(vim.fs.dirname(pkg_path))
chrisgrieser
approved these changes
Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mason.nvimhas been pinned to thev1.xbranch since the v2 release, this unpins it. Not a lot of changes. Instead of manually parsing the package spec and instantiating a Package instance this is now entirely done viamason.nvimvia thefile:registry protocol, keeps things a bit simpler.