-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: anywidget refresh value #9454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
0b9b933
a65acfb
5ff656c
bef476a
9e4fb8f
c56976b
2aa2d5e
59d80f2
0cab748
cc7879c
af8fb2a
7fac9de
8058be6
771cafa
5f6d6c8
b96acc8
c1b3b86
444fa75
bba0f1b
68af249
af7131b
9c8b430
90cdbfe
a92660c
8d5845e
328beca
ee521cc
aeb5dc7
e085c96
0b5f359
9d75eb8
718d8a4
190574e
49cb2eb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -132,3 +132,6 @@ pixi.lock | |
|
|
||
| # mkdocs | ||
| site | ||
|
|
||
| .agents/ | ||
| *skills* | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -95,7 +95,9 @@ def _create_model_message( | |
| ) -> ModelMessage | None: | ||
| """Create the appropriate ModelMessage based on the method field. | ||
|
|
||
| Returns None for methods that should be skipped (e.g., echo_update). | ||
| Returns None for unknown methods that should be skipped. | ||
| `echo_update` is converted to `ModelUpdate` to preserve | ||
| frontend-driven trait changes for reconnect replay. | ||
| """ | ||
| bbuffers = [_ensure_bytes(b) for b in buffers] | ||
| method = data.get("method", "update") | ||
|
|
@@ -120,8 +122,14 @@ def _create_model_message( | |
| buffers=bbuffers, | ||
| ) | ||
| elif method == "echo_update": | ||
| # echo_update is for multi-client sync acknowledgment, skip it | ||
| return None | ||
| # Preserve frontend-driven trait changes for reconnect replay. | ||
| # anywidget/ipywidgets can emit echo_update as the synchronisation | ||
| # acknowledgement path; dropping it causes stale replay state. | ||
| return ModelUpdate( | ||
|
Comment on lines
124
to
+128
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agreed.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hello @manzt If you could take a look at this, before it becomes stale, that would be great. Thank you |
||
| state=state, | ||
| buffer_paths=buffer_paths, | ||
| buffers=bbuffers, | ||
| ) | ||
| else: | ||
| LOGGER.warning("Unknown method: %s, skipping", method) | ||
| return None | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.