Torch 2.9.0 support#676
Open
hcollin-phoenix wants to merge 1 commit into
Open
Conversation
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @marcoslucianops,
This pull request proposes changing the export scripts to support torch version 2.9.0 by specifying Dynamo value as specified in the release note.
The problem
Currently, the export is not working with version 2.9.0.
I initially had the issue with D-FINE but seeing this issue, i made the changes for all.
Solution
By setting the default value of dynamo to False, we ensure that it is compatible with newer versions.
Thanks for considering the change.