Surface an error when the worker script fails to load (#8018) - #8089
Closed
clement-igonet wants to merge 4 commits into
Closed
Surface an error when the worker script fails to load (#8018)#8089clement-igonet wants to merge 4 commits into
clement-igonet wants to merge 4 commits into
Conversation
A worker error arriving before its first message is a script load failure: report it on the console from the worker factory and fire the map error event through the dispatcher, instead of hanging silently. Assisted-By: Claude <noreply@anthropic.com>
…opy in the worker mock, drop unneeded assertions, update bundle size Assisted-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8089 +/- ##
==========================================
+ Coverage 93.33% 93.37% +0.04%
==========================================
Files 291 291
Lines 24603 24631 +28
Branches 6494 6497 +3
==========================================
+ Hits 22962 22998 +36
+ Misses 1641 1633 -8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
This is just rude now. |
Contributor
Author
#8024 was already open for this and I should have checked before opening anything. Closing was correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the worker script fails to load (wrong
setWorkerUrl(), missing self-hosted bundle, blocked import), the map now says so instead of hanging silently: the map fires anerrorevent with an actionable message, and the console shows the same with the worker URL. Only an error arriving before the worker's first message is treated as a load failure, so runtime errors of a healthy worker are not affected.On the issue's repro, instead of nothing:
Also fixes the silent hang analyzed in #8074.
Launch Checklist
CHANGELOG.mdunder the## mainsection.Assisted-By: Claude (claude-fable-5)