[Bugfix] Vary sub-scene pick clutter object targets.#1091
Open
Gamenot wants to merge 1 commit into
Open
Conversation
Previous implementation selected from only the last sub-scene causing scene cross contamination if `target_object` was used.
Member
|
Thank you! I will try and review this early next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous implementation selected target objects from only the last sub-scene (-1) causing scene cross-contamination if information from
target_objectwas used. Original RL behavior after implementing the rewards generally resulted in reaching to a constant location on parallel environments due to referencing objects from a single scene.Improvements:
num_envs.