Skip to content

Fix iOS composer compile break (nonisolated image helpers) #6198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lawrencecchen wants to merge 2 commits into from
Closed

Fix iOS composer compile break (nonisolated image helpers) #6198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d61b370
Fix iOS composer compile break: mark image helpers nonisolated
lawrencecchen Jun 16, 2026
ffadba7
Composer fix: also mark the size-cap constants nonisolated (Swift 6)
lawrencecchen Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Packages/CmuxMobileShell/Sources/CmuxMobileShell/MobileShellComposite.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,9 @@ public final class MobileShellComposite: MobileTerminalOutputSinking {
/// Per-image encoded-bytes cap. An add whose single image exceeds this is
/// rejected outright (the view bounds the encode below this, but the store
/// re-enforces it as the single source of truth).
public static let maxPendingAttachmentImageBytes = 8 * 1024 * 1024
// nonisolated so the composer's off-main (nonisolated) image-encode path can
// read the authoritative per-image cap; it is an immutable Sendable literal.
public nonisolated static let maxPendingAttachmentImageBytes = 8 * 1024 * 1024
/// GLOBAL encoded-bytes budget summed across EVERY terminal's staged set, not
/// just the target's. The per-terminal cap bounds one draft, but each live
/// terminal carries its own per-terminal budget, so staging photos across many
Expand Down
10 changes: 5 additions & 5 deletions Packages/CmuxMobileShellUI/Sources/CmuxMobileShellUI/TerminalComposerView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ struct TerminalComposerView: View {
/// clipboard paste path and keep the bounded encode under ~8 MB. The store
/// re-enforces this as the authoritative per-image cap; this constant only
/// bounds the encode loop below it.
private static let maxImageBytes = CMUXMobileShellStore.maxPendingAttachmentImageBytes
private nonisolated static let maxImageBytes = CMUXMobileShellStore.maxPendingAttachmentImageBytes

/// Cap how many images one message may carry, mirrored from the store so the
/// picker's `maxSelectionCount` matches the store's authoritative count cap.
Expand All @@ -137,14 +137,14 @@ struct TerminalComposerView: View {

/// Max pixel dimension of the cached chip thumbnail. The chip renders at 56pt;
/// 3x covers Retina without holding the full-resolution image.
private static let thumbnailMaxPixelSize = 168
private nonisolated static let thumbnailMaxPixelSize = 168

/// Max pixel dimension of the SEND payload. ImageIO downsamples the picked
/// item to fit this longest edge before re-encoding, so a panorama or a
/// 48-megapixel HEIC never materializes as a full-resolution raster. 2048 px
/// keeps screenshot text legible for an agent while bounding the bytes well
/// under the per-image cap.
private static let sendMaxPixelSize = 2048
private nonisolated static let sendMaxPixelSize = 2048

var body: some View {
composerSurface
Expand Down Expand Up @@ -542,7 +542,7 @@ struct TerminalComposerView: View {
/// 3. Progressively smaller dimensions as a last resort.
/// Returns the encoded bytes + a lowercase format hint, or `nil` if the source
/// is undecodable. The cap is also re-enforced authoritatively in the store.
private static func boundedSendPayload(from source: CGImageSource) -> (data: Data, format: String)? {
private nonisolated static func boundedSendPayload(from source: CGImageSource) -> (data: Data, format: String)? {
// PNG at the bounded send size: lossless, and for a typical screenshot it
// lands well under the cap.
if let png = downsampledImageData(
Expand Down Expand Up @@ -599,7 +599,7 @@ struct TerminalComposerView: View {
/// - maxPixelSize: The longest-edge cap, in pixels, for the downsample.
/// - type: The destination UTType identifier (`"public.png"`/`"public.jpeg"`).
/// - jpegQuality: The JPEG compression quality (0...1); `nil` for PNG.
private static func downsampledImageData(
private nonisolated static func downsampledImageData(
from source: CGImageSource,
maxPixelSize: Int,
type: String,
Expand Down