-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Decouple iOS primary terminal scroll #6081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lawrencecchen
wants to merge
21
commits into
main
Choose a base branch
from
feat-ios-smooth-scroll-demo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 20 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
2c43d31
Decouple iOS primary terminal scroll
lawrencecchen eee05fb
Configure iOS dev API base URL
lawrencecchen 25eb92e
Fix iOS native auth LAN callback
lawrencecchen 2438ab6
Fix native auth route tests
lawrencecchen 171d624
Add iOS science demo bypass
lawrencecchen 8e4636f
Improve iOS science demo scrollback
lawrencecchen a8b2ead
Update Ghostty pixel scroll renderer
lawrencecchen a1697cc
Enable desktop smooth scroll path
lawrencecchen c156503
Use wheel events for desktop smooth scroll
lawrencecchen f82bcbf
Use fractional row offsets for desktop smooth scroll
lawrencecchen aff8198
Add debug fractional scroll verification hook
lawrencecchen b6e9f97
Fix smooth scroll fractional direction
lawrencecchen f73e2c3
Preload Ghostty rows for smooth scroll edges
lawrencecchen 415b28b
Add iOS instant terminal scroll mode
lawrencecchen c617afa
Hydrate iOS terminal replay with full scrollback
lawrencecchen d0797e3
Fix pixel scroll boundary clamp
lawrencecchen ed18dda
Retry mobile replay after workspace mapping
lawrencecchen 6b54974
Fix mobile dogfood attach during session restore
lawrencecchen a7c2a20
Merge remote-tracking branch 'origin/main' into feat-ios-smooth-scrol…
lawrencecchen e05ca47
Fix iOS local scrollback offset control
lawrencecchen c3b8822
Gate iOS replay on terminal geometry
lawrencecchen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
15 changes: 15 additions & 0 deletions
15
Packages/CMUXMobileCore/Sources/CMUXMobileCore/MobileTerminalScrollbackBudget.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| public enum MobileTerminalScrollbackBudget { | ||
| /// Small fallback used when an older client asks for replay without an | ||
| /// explicit scrollback window. | ||
| public static let defaultReplayRows = 240 | ||
|
|
||
| /// Bounded repair window for host-coupled scroll responses. The decoupled | ||
| /// primary-screen path should not depend on this during normal iPhone | ||
| /// scrolling. | ||
| public static let scrollPrefetchRows = 600 | ||
| } | ||
|
|
||
| public enum MobileTerminalScrollbackReplayRequest { | ||
| public static let scopeParameter = "scrollback_scope" | ||
| public static let fullScope = "full" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.