-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Reduce iOS workspace row swipe contention #6064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
f979651
Reduce iOS workspace row swipe contention
azooz2003-bit f4af2f3
Reduce mobile workspace avatar render cost
azooz2003-bit 7093e1c
Use navigation links for compact workspace rows
azooz2003-bit 3dc7672
Keep device tree workspace rows as buttons
azooz2003-bit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NavigationLink(value: workspace.id)andsimultaneousGesture(TapGesture().onEnded { selectWorkspace(workspace.id) })both fire on the same tap.selectWorkspace(line 182–184 ofWorkspaceShellView) guards withcompactNavigationPath.last != idbefore setting the path to[id]— but that guard is only effective if the NavigationLink has already appendedidto the path first. If the SwiftUITapGesturefires before UIKit/NavigationStack processes the link activation (making the path still[]),selectWorkspacesetscompactNavigationPath = [id]and then the NavigationLink appendsidagain, yielding[id, id]. The NavigationStack would then push the workspace detail view twice, leaving a stale intermediate destination in the back-stack. SincesimultaneousGesturemakes the ordering undefined, this race is present even though it may not reproduce consistently on any given device.