Implement and stabilize the paper canvas pane strip

.github/workflows/test-e2e.yml

@@ -187,6 +187,10 @@ jobs:
           set -euo pipefail
           SOURCE_PACKAGES_DIR="$PWD/.ci-source-packages"
           ONLY_TESTING="-only-testing:cmuxUITests/$TEST_FILTER"
+          OUTPUT_FILE="$(mktemp -t cmux-e2e-output.XXXXXX)"
+          RESULT_BUNDLE="/tmp/cmux-ui-tests.xcresult"
+          trap 'rm -f "$OUTPUT_FILE"' EXIT
+          rm -rf "$RESULT_BUNDLE"
 
           # Start recording right before the test (after build/resolve)
           if [ "$RECORD_VIDEO" = "true" ]; then
@@ -216,19 +220,20 @@ jobs:
           fi
 
           set +e
-          OUTPUT=$(xcodebuild -project GhosttyTabs.xcodeproj -scheme cmux -configuration Debug \
+          xcodebuild -project GhosttyTabs.xcodeproj -scheme cmux -configuration Debug \
             -clonedSourcePackagesDirPath "$SOURCE_PACKAGES_DIR" \
             -disableAutomaticPackageResolution \
             -destination "platform=macOS" \
             -maximum-test-execution-time-allowance "$TEST_TIMEOUT" \
-            $ONLY_TESTING test 2>&1)
+            -resultBundlePath "$RESULT_BUNDLE" \
+            $ONLY_TESTING test >"$OUTPUT_FILE" 2>&1
           EXIT_CODE=$?
           set -e
 
-          echo "$OUTPUT"
+          cat "$OUTPUT_FILE"
 
           # Save summary for the issue
-          SUMMARY=$(echo "$OUTPUT" | grep -E "(Test Suite|Executed|FAIL|PASS)" | tail -20)
+          SUMMARY=$(grep -E "(Test Suite|Executed|FAIL|PASS)" "$OUTPUT_FILE" | tail -20 || true)
           {
             echo "test_summary<<EOFSUM"
             echo "$SUMMARY"
@@ -242,7 +247,7 @@ jobs:
             # Save full output for the issue body
             {
               echo "test_output<<EOFOUT"
-              echo "$OUTPUT" | tail -200
+              tail -200 "$OUTPUT_FILE"
               echo "EOFOUT"
             } >> "$GITHUB_OUTPUT"
             exit 1
@@ -297,6 +302,14 @@ jobs:
           path: /tmp/test-recording.mp4
           if-no-files-found: warn
 
+      - name: Upload xcresult artifact
+        if: ${{ always() }}
+        uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
+        with:
+          name: ui-test-xcresult
+          path: /tmp/cmux-ui-tests.xcresult
+          if-no-files-found: warn
+
       - name: Post results to cmux-dev-artifacts
         if: always()
         env:

.gitmodules

@@ -5,6 +5,3 @@
 [submodule "homebrew-cmux"]
 	path = homebrew-cmux
 	url = https://github.com/manaflow-ai/homebrew-cmux.git
-[submodule "vendor/bonsplit"]
-	path = vendor/bonsplit
-	url = https://github.com/manaflow-ai/bonsplit.git

CLI/cmux.swift

@@ -1406,6 +1406,38 @@ struct CMUXCLI {
                 print(response)
             }
 
+        case "pan-workspace":
+            let workspaceArg = workspaceFromArgsOrEnv(commandArgs, windowOverride: windowId)
+            let dxRaw = optionValue(commandArgs, name: "--dx")
+            let dyRaw = optionValue(commandArgs, name: "--dy")
+            let dx: Int
+            if let dxRaw {
+                guard let parsed = Int(dxRaw) else {
+                    throw CLIError(message: String(localized: "cli.pan-workspace.error.dxInteger", defaultValue: "--dx must be an integer"))
+                }
+                dx = parsed
+            } else {
+                dx = 0
+            }
+            let dy: Int
+            if let dyRaw {
+                guard let parsed = Int(dyRaw) else {
+                    throw CLIError(message: String(localized: "cli.pan-workspace.error.dyInteger", defaultValue: "--dy must be an integer"))
+                }
+                dy = parsed
+            } else {
+                dy = 0
+            }
+            guard dx != 0 || dy != 0 else {
+                throw CLIError(message: String(localized: "cli.pan-workspace.error.requiresDelta", defaultValue: "pan-workspace requires a non-zero --dx and/or --dy"))
+            }
+
+            var params: [String: Any] = ["dx": dx, "dy": dy]
+            let wsId = try normalizeWorkspaceHandle(workspaceArg, client: client, allowCurrent: true)
+            if let wsId { params["workspace_id"] = wsId }
+            let payload = try client.sendV2(method: "workspace.viewport.pan", params: params)
+            printV2Payload(payload, jsonOutput: jsonOutput, idFormat: idFormat, fallbackText: v2OKSummary(payload, idFormat: idFormat, kinds: ["workspace"]))
+
         case "read-screen":
             let (wsArg, rem0) = parseOption(commandArgs, name: "--workspace")
             let (sfArg, rem1) = parseOption(rem0, name: "--surface")
@@ -4522,6 +4554,9 @@ struct CMUXCLI {
 
             Split the current pane in the given direction.
 
+            Note:
+              Horizontal pane-strip workspaces reject up/down splits with not_supported.
+
             Flags:
               --workspace <id|ref>   Target workspace (default: $CMUX_WORKSPACE_ID)
               --surface <id|ref>     Surface to split from (default: $CMUX_SURFACE_ID)
@@ -4766,6 +4801,26 @@ struct CMUXCLI {
 
             Print the currently selected workspace ID.
             """
+        case "pan-workspace":
+            return String(localized: "cli.pan-workspace.usage", defaultValue: """
+            Usage: cmux pan-workspace [--workspace <id|ref|index>] [--dx <pixels>] [--dy <pixels>]
+
+            Pan the paper-canvas viewport for a workspace.
+
+            Flags:
+              --workspace <id|ref|index>   Workspace to pan (default: current/$CMUX_WORKSPACE_ID)
+              --dx <pixels>                Horizontal pan delta in pixels
+              --dy <pixels>                Vertical pan delta in pixels
+
+            Notes:
+              Positive --dx pans right, negative pans left.
+              Positive --dy pans down, negative pans up.
+              At least one of --dx or --dy must be non-zero.
+
+            Example:
+              cmux pan-workspace --dx 400
+              cmux pan-workspace --workspace workspace:2 --dx -240 --dy 180
+            """)
         case "capture-pane":
             return """
             Usage: cmux capture-pane [--workspace <id|ref>] [--surface <id|ref>] [--scrollback] [--lines <n>]
@@ -8412,6 +8467,7 @@ struct CMUXCLI {
           workspace-action --action <name> [--workspace <id|ref|index>] [--title <text>]
           list-workspaces
           new-workspace [--cwd <path>] [--command <text>]
+          pan-workspace [--workspace <id|ref|index>] [--dx <pixels>] [--dy <pixels>]
           new-split <left|right|up|down> [--workspace <id|ref>] [--surface <id|ref>] [--panel <id|ref>]
           list-panes [--workspace <id|ref>]
           list-pane-surfaces [--workspace <id|ref>] [--pane <id|ref>]

GhosttyTabs.xcodeproj/project.pbxproj

@@ -76,6 +76,7 @@
 			B8F266236A1A3D9A45BD840F /* SidebarResizeUITests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 818DBCD4AB69EB72573E8138 /* SidebarResizeUITests.swift */; };
 			B8F266246A1A3D9A45BD840F /* SidebarHelpMenuUITests.swift in Sources */ = {isa = PBXBuildFile; fileRef = B8F266256A1A3D9A45BD840F /* SidebarHelpMenuUITests.swift */; };
 			C0B4D9B0A1B2C3D4E5F60718 /* UpdatePillUITests.swift in Sources */ = {isa = PBXBuildFile; fileRef = C0B4D9B1A1B2C3D4E5F60718 /* UpdatePillUITests.swift */; };
+			E2000010A1B2C3D4E5F60718 /* PaneStripUITests.swift in Sources */ = {isa = PBXBuildFile; fileRef = E2000011A1B2C3D4E5F60718 /* PaneStripUITests.swift */; };
 					B9000014A1B2C3D4E5F60719 /* JumpToUnreadUITests.swift in Sources */ = {isa = PBXBuildFile; fileRef = B9000013A1B2C3D4E5F60719 /* JumpToUnreadUITests.swift */; };
 					B9000015A1B2C3D4E5F60719 /* MultiWindowNotificationsUITests.swift in Sources */ = {isa = PBXBuildFile; fileRef = B9000016A1B2C3D4E5F60719 /* MultiWindowNotificationsUITests.swift */; };
 					B900001AA1B2C3D4E5F60719 /* CloseWorkspaceConfirmDialogUITests.swift in Sources */ = {isa = PBXBuildFile; fileRef = B9000019A1B2C3D4E5F60719 /* CloseWorkspaceConfirmDialogUITests.swift */; };
@@ -213,6 +214,7 @@
 		818DBCD4AB69EB72573E8138 /* SidebarResizeUITests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SidebarResizeUITests.swift; sourceTree = "<group>"; };
 		B8F266256A1A3D9A45BD840F /* SidebarHelpMenuUITests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SidebarHelpMenuUITests.swift; sourceTree = "<group>"; };
 		C0B4D9B1A1B2C3D4E5F60718 /* UpdatePillUITests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = UpdatePillUITests.swift; sourceTree = "<group>"; };
+		E2000011A1B2C3D4E5F60718 /* PaneStripUITests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PaneStripUITests.swift; sourceTree = "<group>"; };
 		A5001101 /* Assets.xcassets */ = {isa = PBXFileReference; lastKnownFileType = folder.assetcatalog; path = Assets.xcassets; sourceTree = "<group>"; };
 		IC000002 /* AppIcon.icon */ = {isa = PBXFileReference; lastKnownFileType = folder; path = AppIcon.icon; sourceTree = "<group>"; };
 		B2E7294509CC42FE9191870E /* xterm-ghostty */ = {isa = PBXFileReference; lastKnownFileType = file; path = "ghostty/terminfo/78/xterm-ghostty"; sourceTree = "<group>"; };
@@ -457,6 +459,7 @@
 							D0E0F0B1A1B2C3D4E5F60718 /* BrowserPaneNavigationKeybindUITests.swift */,
 							D0E0F0B3A1B2C3D4E5F60718 /* BrowserOmnibarSuggestionsUITests.swift */,
 							C0B4D9B1A1B2C3D4E5F60718 /* UpdatePillUITests.swift */,
+							E2000011A1B2C3D4E5F60718 /* PaneStripUITests.swift */,
 						E1000001A1B2C3D4E5F60718 /* MenuKeyEquivalentRoutingUITests.swift */,
 					);
 				path = cmuxUITests;
@@ -504,7 +507,7 @@
 					A5001231 /* Sparkle */,
 					A5001251 /* Sentry */,
 					A5001271 /* PostHog */,
-					A5001261 /* Bonsplit */,
+					A5001261 /* PaneKit */,
 					A5001291 /* MarkdownUI */,
 				);
 			name = GhosttyTabs;
@@ -608,7 +611,7 @@
 					A5001252 /* XCRemoteSwiftPackageReference "sentry-cocoa" */,
 					A5001272 /* XCRemoteSwiftPackageReference "posthog-ios" */,
 					A5001292 /* XCRemoteSwiftPackageReference "swift-markdown-ui" */,
-					A5001260 /* XCLocalSwiftPackageReference "bonsplit" */,
+					A5001260 /* XCLocalSwiftPackageReference "PaneKit" */,
 				);
 			productRefGroup = A5001042 /* Products */;
 			projectDirPath = "";
@@ -697,6 +700,7 @@
 							D0E0F0B0A1B2C3D4E5F60718 /* BrowserPaneNavigationKeybindUITests.swift in Sources */,
 							D0E0F0B2A1B2C3D4E5F60718 /* BrowserOmnibarSuggestionsUITests.swift in Sources */,
 							C0B4D9B0A1B2C3D4E5F60718 /* UpdatePillUITests.swift in Sources */,
+							E2000010A1B2C3D4E5F60718 /* PaneStripUITests.swift in Sources */,
 						E1000000A1B2C3D4E5F60718 /* MenuKeyEquivalentRoutingUITests.swift in Sources */,
 					);
 				runOnlyForDeploymentPostprocessing = 0;
@@ -1034,9 +1038,9 @@
 					minimumVersion = 2.4.1;
 				};
 			};
-			A5001260 /* XCLocalSwiftPackageReference "bonsplit" */ = {
+			A5001260 /* XCLocalSwiftPackageReference "PaneKit" */ = {
 				isa = XCLocalSwiftPackageReference;
-				relativePath = vendor/bonsplit;
+				relativePath = PaneKit;
 			};
 /* End XCRemoteSwiftPackageReference section */
 
@@ -1056,10 +1060,10 @@
 				package = A5001272 /* XCRemoteSwiftPackageReference "posthog-ios" */;
 				productName = PostHog;
 			};
-			A5001261 /* Bonsplit */ = {
+			A5001261 /* PaneKit */ = {
 				isa = XCSwiftPackageProductDependency;
-				package = A5001260 /* XCLocalSwiftPackageReference "bonsplit" */;
-				productName = Bonsplit;
+				package = A5001260 /* XCLocalSwiftPackageReference "PaneKit" */;
+				productName = PaneKit;
 			};
 			A5001291 /* MarkdownUI */ = {
 				isa = XCSwiftPackageProductDependency;

PaneKit/Package.swift

@@ -0,0 +1,28 @@
+// swift-tools-version: 5.9
+
+import PackageDescription
+
+let package = Package(
+    name: "PaneKit",
+    platforms: [
+        .macOS(.v14)
+    ],
+    products: [
+        .library(
+            name: "PaneKit",
+            targets: ["PaneKit"]
+        ),
+    ],
+    targets: [
+        .target(
+            name: "PaneKit",
+            dependencies: [],
+            path: "Sources/PaneKit"
+        ),
+        .testTarget(
+            name: "PaneKitTests",
+            dependencies: ["PaneKit"],
+            path: "Tests/PaneKitTests"
+        ),
+    ]
+)